Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(245)

Issue 847313003: Fix DBus client binding to Manager interface of peerd. (Closed)

Created:
5 years, 11 months ago by dtapuska
Modified:
5 years, 11 months ago
CC:
chromium-reviews, stevenjb+watch_chromium.org, hashimoto+watch_chromium.org, oshima+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix DBus client binding to Manager interface of peerd. Consumers of this API would crash since Init wasn't getting called. Also the incorrect dbus object was getting called. BUG=441765 Committed: https://crrev.com/e8c3bb6ff1cc00179a4ba3b4e0f348418342b1f5 Cr-Commit-Position: refs/heads/master@{#311779}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Adjust dbus manager variable name #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -2 lines) Patch
M chromeos/dbus/dbus_thread_manager.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chromeos/dbus/peer_daemon_manager_client.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 19 (7 generated)
dtapuska
5 years, 11 months ago (2015-01-14 15:21:32 UTC) #2
stevenjb
owner lgtm
5 years, 11 months ago (2015-01-14 16:30:02 UTC) #4
pwestin(chromium)
lgtm
5 years, 11 months ago (2015-01-14 16:44:02 UTC) #5
wiley
https://codereview.chromium.org/847313003/diff/1/chromeos/dbus/peer_daemon_manager_client.cc File chromeos/dbus/peer_daemon_manager_client.cc (right): https://codereview.chromium.org/847313003/diff/1/chromeos/dbus/peer_daemon_manager_client.cc#newcode22 chromeos/dbus/peer_daemon_manager_client.cc:22: const char kPeerdServicePath[] = "/org/chromium/peerd/Manager"; Calling this DBus path ...
5 years, 11 months ago (2015-01-14 18:20:04 UTC) #6
dtapuska
https://codereview.chromium.org/847313003/diff/1/chromeos/dbus/peer_daemon_manager_client.cc File chromeos/dbus/peer_daemon_manager_client.cc (right): https://codereview.chromium.org/847313003/diff/1/chromeos/dbus/peer_daemon_manager_client.cc#newcode22 chromeos/dbus/peer_daemon_manager_client.cc:22: const char kPeerdServicePath[] = "/org/chromium/peerd/Manager"; On 2015/01/14 18:20:03, wiley ...
5 years, 11 months ago (2015-01-14 19:04:34 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/847313003/20001
5 years, 11 months ago (2015-01-14 19:05:56 UTC) #11
commit-bot: I haz the power
All required reviewers (with asterisk prefixes) have not yet approved this CL. No LGTM from ...
5 years, 11 months ago (2015-01-14 19:05:59 UTC) #13
wiley
Thanks! LGTM
5 years, 11 months ago (2015-01-14 20:40:44 UTC) #14
Ben Chan
lgtm
5 years, 11 months ago (2015-01-15 20:36:54 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/847313003/20001
5 years, 11 months ago (2015-01-15 21:28:39 UTC) #17
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 11 months ago (2015-01-16 00:35:50 UTC) #18
commit-bot: I haz the power
5 years, 11 months ago (2015-01-16 00:37:11 UTC) #19
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/e8c3bb6ff1cc00179a4ba3b4e0f348418342b1f5
Cr-Commit-Position: refs/heads/master@{#311779}

Powered by Google App Engine
This is Rietveld 408576698