Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(36)

Issue 847283003: Revert of Relanding this with font test fixes for gdi. (Closed)

Created:
5 years, 11 months ago by jochen (gone - plz use gerrit)
Modified:
5 years, 11 months ago
Reviewers:
msw, ananta
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Relanding this with font test fixes for gdi. (patchset #7 id:120001 of https://codereview.chromium.org/853553002/) Reason for revert: still fails on XP https://build.chromium.org/p/chromium.win/builders/XP%20Tests%20%281%29/builds/34996/steps/gfx_unittests/logs/DeriveFontWithHeight Original issue's description: > Relanding this with font test fixes for gdi. > > Get all font unittests running with DirectWrite on Windows 7+ > > Fixes as per below:- > 1. Remove the addition of the fLeading value when calculating the height for the font > with DirectWrite. fAscent + fDescent is the height of the font and adding the fLeading > value to it returns the spacing between lines which is not what we are looking for. > > 2. The FontListTest.Fonts_GetHeight_GetBaseline unittest has a condition which basically validates > whether the difference between the font height and the baseline is different for Arial and Symbol > fonts. This fails for DirectWrite and fails for GDI with font sizes like 50, etc. Replaced this check > with a check for the font heights are different. > > 3. Reworked the PlatformFontWinTest.DeriveFontWithHeight test to ensure it passes for DirectWrite and GDI. > > 4. Ensure that the PlatformFontWin::DeriveFontWithHeight function honors the minimum font size constraint > in all cases. > > BUG=442010 > R=msw > > Committed: https://crrev.com/3e05f41653bf36cce40718d8295ce2293218dab6 > Cr-Commit-Position: refs/heads/master@{#311388} TBR=msw@chromium.org,ananta@chromium.org NOTREECHECKS=true NOTRY=true BUG=442010 Committed: https://crrev.com/ab0d2cafe050202ea69bbf4dfd9a6f6a39584a44 Cr-Commit-Position: refs/heads/master@{#311424}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+118 lines, -52 lines) Patch
M ui/gfx/font_list_unittest.cc View 1 chunk +6 lines, -6 lines 0 comments Download
M ui/gfx/platform_font_win.h View 2 chunks +9 lines, -4 lines 0 comments Download
M ui/gfx/platform_font_win.cc View 3 chunks +54 lines, -34 lines 0 comments Download
M ui/gfx/platform_font_win_unittest.cc View 2 chunks +49 lines, -8 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
jochen (gone - plz use gerrit)
Created Revert of Relanding this with font test fixes for gdi.
5 years, 11 months ago (2015-01-14 07:47:07 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/847283003/1
5 years, 11 months ago (2015-01-14 07:47:52 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 11 months ago (2015-01-14 07:48:52 UTC) #3
commit-bot: I haz the power
5 years, 11 months ago (2015-01-14 07:50:36 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/ab0d2cafe050202ea69bbf4dfd9a6f6a39584a44
Cr-Commit-Position: refs/heads/master@{#311424}

Powered by Google App Engine
This is Rietveld 408576698