Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(227)

Issue 847273005: More natural way to serialize GPU tasks and tests. (Closed)

Created:
5 years, 11 months ago by mtklein_C
Modified:
5 years, 11 months ago
Reviewers:
hal.canary, mtklein
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

More natural way to serialize GPU tasks and tests. This basically takes out the Windows-only hacks and promotes them to cross-platform behavior driven by --gpu_threading. - When --gpu_threading is false (the default), this puts GPU tasks and tests together in the same GPU enclave. They all run serially. - When --gpu_threading is true, both the tests and the tasks run totally independently, just like the thread-safe CPU-bound work. BUG=skia:3255 Committed: https://skia.googlesource.com/skia/+/55e88b226ccb85d2c712a9e3e9e1f5bdcaac05ac

Patch Set 1 #

Patch Set 2 : rebase #

Total comments: 1

Patch Set 3 : always stack-scope GrContextFactories #

Unified diffs Side-by-side diffs Delta from patch set Stats (+37 lines, -51 lines) Patch
M bench/nanobench.cpp View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M dm/DM.cpp View 1 2 6 chunks +28 lines, -26 lines 0 comments Download
M dm/DMGpuSupport.h View 1 2 1 chunk +0 lines, -2 lines 0 comments Download
D dm/DMGpuSupport.cpp View 1 2 1 chunk +0 lines, -9 lines 0 comments Download
M dm/DMSrcSink.h View 1 1 chunk +1 line, -1 line 0 comments Download
M dm/DMSrcSink.cpp View 1 2 2 chunks +6 lines, -9 lines 0 comments Download
M gyp/dm.gypi View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M tools/flags/SkCommonFlags.cpp View 1 2 1 chunk +1 line, -3 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
mtklein_C
5 years, 11 months ago (2015-01-21 22:12:37 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/847273005/20001
5 years, 11 months ago (2015-01-21 22:15:45 UTC) #4
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
5 years, 11 months ago (2015-01-21 22:15:46 UTC) #5
hal.canary
lgtm with a comment https://codereview.chromium.org/847273005/diff/20001/dm/DM.cpp File dm/DM.cpp (right): https://codereview.chromium.org/847273005/diff/20001/dm/DM.cpp#newcode445 dm/DM.cpp:445: break; What's wrong with tg.batch(Task::Run, ...
5 years, 11 months ago (2015-01-21 22:23:31 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/847273005/40001
5 years, 11 months ago (2015-01-21 23:47:26 UTC) #9
commit-bot: I haz the power
5 years, 11 months ago (2015-01-21 23:50:16 UTC) #10
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://skia.googlesource.com/skia/+/55e88b226ccb85d2c712a9e3e9e1f5bdcaac05ac

Powered by Google App Engine
This is Rietveld 408576698