Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(173)

Unified Diff: tools/auto_bisect/bisect_perf_regression.py

Issue 847273002: Averaging nested result lists instead of flattening them. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/auto_bisect/bisect_perf_regression.py
diff --git a/tools/auto_bisect/bisect_perf_regression.py b/tools/auto_bisect/bisect_perf_regression.py
index 5a66c878901a4e14ceb67480d2ef5141336fa9a9..635adbd3c558c50972f7f35fb3a9ddff03425291 100755
--- a/tools/auto_bisect/bisect_perf_regression.py
+++ b/tools/auto_bisect/bisect_perf_regression.py
@@ -401,19 +401,6 @@ def _TryParseResultValuesFromOutput(metric, text):
values_list = [float(v) for v in values_list
if bisect_utils.IsStringFloat(v)]
- # If the metric is times/t, we need to sum the timings in order to get
- # similar regression results as the try-bots.
- metrics_to_sum = [
- ['times', 't'],
- ['times', 'page_load_time'],
- ['cold_times', 'page_load_time'],
- ['warm_times', 'page_load_time'],
- ]
-
- if metric in metrics_to_sum:
- if values_list:
- values_list = [reduce(lambda x, y: float(x) + float(y), values_list)]
-
return values_list
@@ -1331,7 +1318,8 @@ class BisectPerformanceMetrics(object):
print output
if metric and self._IsBisectModeUsingMetric():
- metric_values += _ParseMetricValuesFromOutput(metric, output)
+ metric_values.append(math_utils.Mean(
+ _ParseMetricValuesFromOutput(metric, output)))
# If we're bisecting on a metric (ie, changes in the mean or
# standard deviation) and no metric values are produced, bail out.
if not metric_values:
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698