Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(56)

Issue 847243005: Allow FPDFBookmark_GetFirstChild to return the top level bookmark (Closed)

Created:
5 years, 11 months ago by Alexandre Carlton
Modified:
5 years, 11 months ago
Reviewers:
Bo Xu, Tom Sepez
Base URL:
https://pdfium.googlesource.com/pdfium.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Allow FPDFBookmark_GetFirstChild to return the top level bookmark Previously when passing a NULL bookmark to FPDFBookmark_GetFirstChild it returned NULL instead of returning the top level bookmark. This change removes the early exit in this case allowing the top level bookmark to be retrieved. BUG=https://code.google.com/p/pdfium/issues/detail?id=110 R=bo_xu@foxitsoftware.com, tsepez@chromium.org Committed: https://pdfium.googlesource.com/pdfium/+/624b166d4f50874f93c6d0824e91cd5b955c0487

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M fpdfsdk/src/fpdfdoc.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 12 (3 generated)
Tom Sepez
On 2015/01/15 02:05:37, Alexandre Carlton wrote: > mailto:alexandrec@chromium.org changed reviewers: > + mailto:bo_xu@foxitsoftware.com, mailto:tsepez@chromium.org What ...
5 years, 11 months ago (2015-01-15 17:20:55 UTC) #2
Bo Xu
LGTM
5 years, 11 months ago (2015-01-15 17:46:40 UTC) #3
Alexandre Carlton
On 2015/01/15 17:20:55, Tom Sepez wrote: > On 2015/01/15 02:05:37, Alexandre Carlton wrote: > > ...
5 years, 11 months ago (2015-01-15 23:38:21 UTC) #4
Tom Sepez
Thank you. LGTM.
5 years, 11 months ago (2015-01-15 23:40:28 UTC) #5
commit-bot: I haz the power
Commit queue rejected this change because it did not recognize the base URL. Please commit ...
5 years, 11 months ago (2015-01-16 01:55:38 UTC) #8
raymes
Is there special permission we need to be able to commit to this repo? We ...
5 years, 11 months ago (2015-01-16 02:11:34 UTC) #9
Tom Sepez
On 2015/01/16 01:55:38, I haz the power (commit-bot) wrote: > Commit queue rejected this change ...
5 years, 11 months ago (2015-01-16 02:13:41 UTC) #10
Tom Sepez
Committed patchset #1 (id:1) manually as 624b166d4f50874f93c6d0824e91cd5b955c0487 (presubmit successful).
5 years, 11 months ago (2015-01-16 02:14:50 UTC) #11
raymes
5 years, 11 months ago (2015-01-16 02:15:45 UTC) #12
Message was sent while issue was closed.
Thanks Tom!!

Powered by Google App Engine
This is Rietveld 408576698