Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(504)

Issue 847193003: Don't allow HTTP origins for the CryptoToken extension. (Closed)

Created:
5 years, 11 months ago by juanlang (chromium.org)
Modified:
5 years, 11 months ago
Reviewers:
xiyuan, Arnar Birgisson
CC:
chromium-reviews, arv+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Don't allow HTTP origins for the CryptoToken extension. BUG=448214 Committed: https://crrev.com/0ee19a51ca3622065360d895415feb0bef6a3a06 Cr-Commit-Position: refs/heads/master@{#311410}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -0 lines) Patch
M chrome/browser/resources/cryptotoken/cryptotokenbackground.js View 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/browser/resources/cryptotoken/enroller.js View 2 chunks +8 lines, -0 lines 0 comments Download
M chrome/browser/resources/cryptotoken/signer.js View 2 chunks +8 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
juanlang (chromium.org)
5 years, 11 months ago (2015-01-14 01:17:39 UTC) #2
Arnar Birgisson
lgtm
5 years, 11 months ago (2015-01-14 01:22:09 UTC) #3
xiyuan
lgtm
5 years, 11 months ago (2015-01-14 01:26:34 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/847193003/1
5 years, 11 months ago (2015-01-14 04:20:15 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 11 months ago (2015-01-14 05:13:32 UTC) #7
commit-bot: I haz the power
5 years, 11 months ago (2015-01-14 05:14:23 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/0ee19a51ca3622065360d895415feb0bef6a3a06
Cr-Commit-Position: refs/heads/master@{#311410}

Powered by Google App Engine
This is Rietveld 408576698