Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(852)

Unified Diff: Source/core/html/HTMLSelectElement.cpp

Issue 84713002: Add number() static methods to AtomicString class (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Pass NaN as default argument Created 7 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/core/html/HTMLProgressElement.cpp ('k') | Source/core/html/HTMLTableCellElement.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/html/HTMLSelectElement.cpp
diff --git a/Source/core/html/HTMLSelectElement.cpp b/Source/core/html/HTMLSelectElement.cpp
index d334e5fc576e2b3aa95d80aa0edcae68196c0c71..7f7980a8249d5e07c350272086106793f9d59e85 100644
--- a/Source/core/html/HTMLSelectElement.cpp
+++ b/Source/core/html/HTMLSelectElement.cpp
@@ -289,7 +289,7 @@ void HTMLSelectElement::parseAttribute(const QualifiedName& name, const AtomicSt
// Set the attribute value to a number.
// This is important since the style rules for this attribute can determine the appearance property.
int size = value.toInt();
- String attrSize = String::number(size);
+ AtomicString attrSize = AtomicString::number(size);
if (attrSize != value) {
// FIXME: This is horribly factored.
if (Attribute* sizeAttribute = ensureUniqueElementData()->getAttributeItem(sizeAttr))
@@ -401,7 +401,7 @@ void HTMLSelectElement::setMultiple(bool multiple)
void HTMLSelectElement::setSize(int size)
{
- setAttribute(sizeAttr, String::number(size));
+ setIntegralAttribute(sizeAttr, size);
}
Node* HTMLSelectElement::namedItem(const AtomicString& name)
« no previous file with comments | « Source/core/html/HTMLProgressElement.cpp ('k') | Source/core/html/HTMLTableCellElement.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698