Source/bindings/v8/V8StringResource.cpp - Issue 84713002: Add number() static methods to AtomicString class

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/bindings/v8/V8StringResource.cpp

Issue 84713002: Add number() static methods to AtomicString class (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Pass NaN as default argument Created 7 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/bindings/v8/V8StringResource.cpp

diff --git a/Source/bindings/v8/V8StringResource.cpp b/Source/bindings/v8/V8StringResource.cpp

index 22e5a487f9ad4aef90485d3f64720fe3ae352ff3..888d1c24937e1649d2beee3f11cca6dd2c23a67d 100644

--- a/Source/bindings/v8/V8StringResource.cpp

+++ b/Source/bindings/v8/V8StringResource.cpp

@@ -187,7 +187,7 @@ String int32ToWebCoreStringFast(int value)

if (0 <= value && value <= kLowNumbers) {

webCoreString = lowNumbers[value];

if (!webCoreString) {

- AtomicString valueString = AtomicString(String::number(value));

+ AtomicString valueString = AtomicString::number(value);

lowNumbers[value] = valueString;

webCoreString = valueString;

}

« no previous file with comments | « no previous file | Source/core/dom/DOMStringMap.h » ('j') | no next file with comments »