Source/core/html/shadow/MediaControlElements.cpp - Issue 84713002: Add number() static methods to AtomicString class

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/html/shadow/MediaControlElements.cpp

Issue 84713002: Add number() static methods to AtomicString class (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Take feedback into consideration (getting AppEngine errors...) Created 7 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/core/html/shadow/MediaControlElements.cpp

diff --git a/Source/core/html/shadow/MediaControlElements.cpp b/Source/core/html/shadow/MediaControlElements.cpp

index c76cb41b5b7c02479a8064dffad9e89074f40e5c..03abf2374376372bf9f8ce21ebe58315ec50d193 100644

--- a/Source/core/html/shadow/MediaControlElements.cpp

+++ b/Source/core/html/shadow/MediaControlElements.cpp

@@ -519,7 +519,7 @@ void MediaControlTimelineElement::setPosition(double currentTime)

void MediaControlTimelineElement::setDuration(double duration)

{

- setAttribute(maxAttr, String::number(std::isfinite(duration) ? duration : 0));

+ setFloatingPointAttribute(maxAttr, std::isfinite(duration) ? duration : 0);

}