Add number() static methods to AtomicString class

Source/core/dom/Element.cpp

 /*
  * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
  *           (C) 1999 Antti Koivisto (koivisto@kde.org)
  *           (C) 2001 Peter Kelly (pmk@post.com)
  *           (C) 2001 Dirk Mueller (mueller@kde.org)
  *           (C) 2007 David Smith (catfish.man@gmail.com)
  * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2010, 2012, 2013 Apple Inc. All rights reserved.
  *           (C) 2007 Eric Seidel (eric@webkit.org)
  *
  * This library is free software; you can redistribute it and/or
@@ skipping 2734 matching lines @@
     return document().completeURL(value);
 }
 
 int Element::getIntegralAttribute(const QualifiedName& attributeName) const
 {
     return getAttribute(attributeName).string().toInt();
 }
 
 void Element::setIntegralAttribute(const QualifiedName& attributeName, int value)
 {
-    // FIXME: Need an AtomicString version of String::number.
-    setAttribute(attributeName, String::number(value));
+    setAttribute(attributeName, AtomicString::number(value));
 }
 
 unsigned Element::getUnsignedIntegralAttribute(const QualifiedName& attributeName) const
 {
     return getAttribute(attributeName).string().toUInt();
 }
 
 void Element::setUnsignedIntegralAttribute(const QualifiedName& attributeName, unsigned value)
 {
-    // FIXME: Need an AtomicString version of String::number.
-    setAttribute(attributeName, String::number(value));
+    setAttribute(attributeName, AtomicString::number(value));
+}
+
+double Element::getFloatingPointAttribute(const QualifiedName& attributeName, double fallbackValue) const

[eseidel, 2013/11/25 00:46:43]

This is the same as the next function.  We just need to figure out what
"parseToDoubleForNumberType" returns on failure and make that the default
fallbackValue.

getFloatingPointAttribute(QualifiedName, double fallback = 0); for instance.  I
presume all of these getters will want a fallback value and can just pass it
along to parseToDoubleForNumberType.

[Inactive, 2013/11/25 01:19:38]

parseToDoubleForNumberType() uses std::numeric_limits<double>::quiet_NaN() as
default fallback value.

I followed the pattern used by parseToDoubleForNumberType():
double parseToDoubleForNumberType(const String&);
double parseToDoubleForNumberType(const String&, double fallbackValue);

I can update it to:
double parseToDoubleForNumberType(const String&, double fallbackValue =
std::numeric_limits<double>::quiet_NaN());

and them do the same for the Element helper method. I'll do that.

[Inactive, 2013/11/25 01:28:13]

Done.

+{
+    return parseToDoubleForNumberType(getAttribute(attributeName), fallbackValue);
+}
+
+double Element::getFloatingPointAttribute(const QualifiedName& attributeName) const
+{
+    return parseToDoubleForNumberType(getAttribute(attributeName));
+}
+
+void Element::setFloatingPointAttribute(const QualifiedName& attributeName, double value)
+{
+    setAttribute(attributeName, AtomicString::number(value));
 }
 
 bool Element::childShouldCreateRenderer(const Node& child) const
 {
     // Only create renderers for SVG elements whose parents are SVG elements, or for proper <svg xmlns="svgNS"> subdocuments.
     if (child.isSVGElement())
         return child.hasTagName(SVGNames::svgTag) || isSVGElement();
 
     return ContainerNode::childShouldCreateRenderer(child);
 }
@@ skipping 751 matching lines @@
     // Before doing so, we need to resolve issues in HTMLSelectElement::recalcListItems
     // and RenderMenuList::setText. See also https://bugs.webkit.org/show_bug.cgi?id=88405
     if (hasTagName(optionTag) || hasTagName(optgroupTag))
         return false;
     if (FullscreenElementStack::isActiveFullScreenElement(this))
         return false;
     return true;
 }
 
 } // namespace WebCore