Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(136)

Issue 847093002: Make UBSan happy about OpParameter casts. (Closed)

Created:
5 years, 11 months ago by Michael Starzinger
Modified:
5 years, 11 months ago
Reviewers:
Sven Panne
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Make UBSan happy about OpParameter casts. R=svenpanne@chromium.org BUG=chromium:448141 LOG=N Committed: https://crrev.com/c36b5ac6252ea71701c44a68819f5b96f79b91ed Cr-Commit-Position: refs/heads/master@{#26042}

Patch Set 1 #

Patch Set 2 : One more instance. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -6 lines) Patch
M src/compiler/operator.h View 1 2 chunks +8 lines, -6 lines 0 comments Download

Messages

Total messages: 8 (1 generated)
Michael Starzinger
5 years, 11 months ago (2015-01-13 10:42:02 UTC) #1
Sven Panne
Using reinterpret_cast doesn't make the underlying problem go away: There is a mismatch in the ...
5 years, 11 months ago (2015-01-13 11:01:58 UTC) #2
Sven Panne
LGTM. As discussed offline: Let's land it as it is to unblock things, but please ...
5 years, 11 months ago (2015-01-13 12:52:14 UTC) #3
Michael Starzinger
OK, thanks. I have opened https://code.google.com/p/v8/issues/detail?id=3809 to keep track of this. Will land this workaround.
5 years, 11 months ago (2015-01-13 13:01:47 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/847093002/20001
5 years, 11 months ago (2015-01-13 13:03:44 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 11 months ago (2015-01-13 13:38:45 UTC) #7
commit-bot: I haz the power
5 years, 11 months ago (2015-01-13 13:38:57 UTC) #8
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/c36b5ac6252ea71701c44a68819f5b96f79b91ed
Cr-Commit-Position: refs/heads/master@{#26042}

Powered by Google App Engine
This is Rietveld 408576698