Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(624)

Issue 847083002: replace COMPILE_ASSERT with static_assert in appcache_frontend_impl.cc (Closed)

Created:
5 years, 11 months ago by Mostyn Bramley-Moore
Modified:
5 years, 11 months ago
Reviewers:
michaeln
CC:
chromium-reviews, darin-cc_chromium.org, jam
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

replace COMPILE_ASSERT with static_assert in appcache_frontend_impl.cc BUG=442514 Committed: https://crrev.com/3cb31c320b8970c192c2baf32c35a73932911adb Cr-Commit-Position: refs/heads/master@{#311439}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+41 lines, -63 lines) Patch
M content/child/appcache/appcache_frontend_impl.cc View 1 chunk +41 lines, -63 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
Mostyn Bramley-Moore
@michaeln: please take a look.
5 years, 11 months ago (2015-01-13 08:59:17 UTC) #2
michaeln
lgtm
5 years, 11 months ago (2015-01-13 21:50:33 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/847083002/1
5 years, 11 months ago (2015-01-14 08:55:37 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: ios_dbg_simulator on tryserver.chromium.mac (http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator/builds/48881)
5 years, 11 months ago (2015-01-14 09:00:02 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/847083002/1
5 years, 11 months ago (2015-01-14 09:03:43 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 11 months ago (2015-01-14 09:54:30 UTC) #10
commit-bot: I haz the power
5 years, 11 months ago (2015-01-14 09:55:58 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/3cb31c320b8970c192c2baf32c35a73932911adb
Cr-Commit-Position: refs/heads/master@{#311439}

Powered by Google App Engine
This is Rietveld 408576698