Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(18)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 847073002: Convert some fast/selectors tests to reftests. (Closed)

Created:
5 years, 11 months ago by rune
Modified:
5 years, 11 months ago
CC:
blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Convert some fast/selectors tests to reftests. Removed fast/selectors/005.html since it was identical to 004.html Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=188312

Patch Set 1 #

Total comments: 2

Patch Set 2 : Use style attribute in references #

Unified diffs Side-by-side diffs Delta from patch set Stats (+65 lines, -900 lines) Patch
A LayoutTests/fast/selectors/001-expected.html View 1 1 chunk +6 lines, -0 lines 0 comments Download
A LayoutTests/fast/selectors/002-expected.html View 1 chunk +2 lines, -0 lines 0 comments Download
A LayoutTests/fast/selectors/003-expected.html View 1 chunk +2 lines, -0 lines 0 comments Download
A LayoutTests/fast/selectors/004-expected.html View 1 chunk +2 lines, -0 lines 0 comments Download
D LayoutTests/fast/selectors/005.html View 1 chunk +0 lines, -18 lines 0 comments Download
A LayoutTests/fast/selectors/006-expected.html View 1 chunk +3 lines, -0 lines 0 comments Download
A LayoutTests/fast/selectors/007a-expected.html View 1 1 chunk +6 lines, -0 lines 0 comments Download
A LayoutTests/fast/selectors/007b-expected.html View 1 chunk +2 lines, -0 lines 0 comments Download
A LayoutTests/fast/selectors/008-expected.html View 1 1 chunk +4 lines, -0 lines 0 comments Download
A LayoutTests/fast/selectors/009-expected.html View 1 chunk +3 lines, -0 lines 0 comments Download
A LayoutTests/fast/selectors/010-expected.html View 1 chunk +3 lines, -0 lines 0 comments Download
A LayoutTests/fast/selectors/011-expected.html View 1 chunk +3 lines, -0 lines 0 comments Download
A LayoutTests/fast/selectors/012-expected.html View 1 chunk +4 lines, -0 lines 0 comments Download
A LayoutTests/fast/selectors/013-expected.html View 1 1 chunk +6 lines, -0 lines 0 comments Download
A LayoutTests/fast/selectors/014-expected.html View 1 chunk +4 lines, -0 lines 0 comments Download
A LayoutTests/fast/selectors/015-expected.html View 1 1 chunk +6 lines, -0 lines 0 comments Download
A LayoutTests/fast/selectors/016-expected.html View 1 chunk +5 lines, -0 lines 0 comments Download
A LayoutTests/fast/selectors/017-expected.html View 1 chunk +4 lines, -0 lines 0 comments Download
D LayoutTests/platform/linux/fast/selectors/001-expected.png View Binary file 0 comments Download
D LayoutTests/platform/linux/fast/selectors/001-expected.txt View 1 chunk +0 lines, -17 lines 0 comments Download
D LayoutTests/platform/linux/fast/selectors/002-expected.png View Binary file 0 comments Download
D LayoutTests/platform/linux/fast/selectors/002-expected.txt View 1 chunk +0 lines, -8 lines 0 comments Download
D LayoutTests/platform/linux/fast/selectors/003-expected.png View Binary file 0 comments Download
D LayoutTests/platform/linux/fast/selectors/003-expected.txt View 1 chunk +0 lines, -8 lines 0 comments Download
D LayoutTests/platform/linux/fast/selectors/004-expected.png View Binary file 0 comments Download
D LayoutTests/platform/linux/fast/selectors/004-expected.txt View 1 chunk +0 lines, -9 lines 0 comments Download
D LayoutTests/platform/linux/fast/selectors/005-expected.png View Binary file 0 comments Download
D LayoutTests/platform/linux/fast/selectors/005-expected.txt View 1 chunk +0 lines, -9 lines 0 comments Download
D LayoutTests/platform/linux/fast/selectors/006-expected.png View Binary file 0 comments Download
D LayoutTests/platform/linux/fast/selectors/006-expected.txt View 1 chunk +0 lines, -15 lines 0 comments Download
D LayoutTests/platform/linux/fast/selectors/007a-expected.png View Binary file 0 comments Download
D LayoutTests/platform/linux/fast/selectors/007a-expected.txt View 1 chunk +0 lines, -20 lines 0 comments Download
D LayoutTests/platform/linux/fast/selectors/007b-expected.png View Binary file 0 comments Download
D LayoutTests/platform/linux/fast/selectors/007b-expected.txt View 1 chunk +0 lines, -8 lines 0 comments Download
D LayoutTests/platform/linux/fast/selectors/008-expected.png View Binary file 0 comments Download
D LayoutTests/platform/linux/fast/selectors/008-expected.txt View 1 chunk +0 lines, -19 lines 0 comments Download
D LayoutTests/platform/linux/fast/selectors/009-expected.png View Binary file 0 comments Download
D LayoutTests/platform/linux/fast/selectors/009-expected.txt View 1 chunk +0 lines, -11 lines 0 comments Download
D LayoutTests/platform/linux/fast/selectors/010-expected.png View Binary file 0 comments Download
D LayoutTests/platform/linux/fast/selectors/010-expected.txt View 1 chunk +0 lines, -8 lines 0 comments Download
D LayoutTests/platform/linux/fast/selectors/011-expected.png View Binary file 0 comments Download
D LayoutTests/platform/linux/fast/selectors/011-expected.txt View 1 chunk +0 lines, -8 lines 0 comments Download
D LayoutTests/platform/linux/fast/selectors/012-expected.png View Binary file 0 comments Download
D LayoutTests/platform/linux/fast/selectors/012-expected.txt View 1 chunk +0 lines, -10 lines 0 comments Download
D LayoutTests/platform/linux/fast/selectors/013-expected.png View Binary file 0 comments Download
D LayoutTests/platform/linux/fast/selectors/013-expected.txt View 1 chunk +0 lines, -21 lines 0 comments Download
D LayoutTests/platform/linux/fast/selectors/014-expected.png View Binary file 0 comments Download
D LayoutTests/platform/linux/fast/selectors/014-expected.txt View 1 chunk +0 lines, -9 lines 0 comments Download
D LayoutTests/platform/linux/fast/selectors/015-expected.png View Binary file 0 comments Download
D LayoutTests/platform/linux/fast/selectors/015-expected.txt View 1 chunk +0 lines, -19 lines 0 comments Download
D LayoutTests/platform/linux/fast/selectors/016-expected.png View Binary file 0 comments Download
D LayoutTests/platform/linux/fast/selectors/016-expected.txt View 1 chunk +0 lines, -11 lines 0 comments Download
D LayoutTests/platform/linux/fast/selectors/017-expected.png View Binary file 0 comments Download
D LayoutTests/platform/linux/fast/selectors/017-expected.txt View 1 chunk +0 lines, -10 lines 0 comments Download
D LayoutTests/platform/mac/fast/selectors/001-expected.png View Binary file 0 comments Download
D LayoutTests/platform/mac/fast/selectors/001-expected.txt View 1 chunk +0 lines, -17 lines 0 comments Download
D LayoutTests/platform/mac/fast/selectors/002-expected.png View Binary file 0 comments Download
D LayoutTests/platform/mac/fast/selectors/002-expected.txt View 1 chunk +0 lines, -8 lines 0 comments Download
D LayoutTests/platform/mac/fast/selectors/003-expected.png View Binary file 0 comments Download
D LayoutTests/platform/mac/fast/selectors/003-expected.txt View 1 chunk +0 lines, -8 lines 0 comments Download
D LayoutTests/platform/mac/fast/selectors/004-expected.png View Binary file 0 comments Download
D LayoutTests/platform/mac/fast/selectors/004-expected.txt View 1 chunk +0 lines, -9 lines 0 comments Download
D LayoutTests/platform/mac/fast/selectors/005-expected.png View Binary file 0 comments Download
D LayoutTests/platform/mac/fast/selectors/005-expected.txt View 1 chunk +0 lines, -9 lines 0 comments Download
D LayoutTests/platform/mac/fast/selectors/006-expected.png View Binary file 0 comments Download
D LayoutTests/platform/mac/fast/selectors/006-expected.txt View 1 chunk +0 lines, -15 lines 0 comments Download
D LayoutTests/platform/mac/fast/selectors/007a-expected.png View Binary file 0 comments Download
D LayoutTests/platform/mac/fast/selectors/007a-expected.txt View 1 chunk +0 lines, -20 lines 0 comments Download
D LayoutTests/platform/mac/fast/selectors/007b-expected.png View Binary file 0 comments Download
D LayoutTests/platform/mac/fast/selectors/007b-expected.txt View 1 chunk +0 lines, -8 lines 0 comments Download
D LayoutTests/platform/mac/fast/selectors/008-expected.png View Binary file 0 comments Download
D LayoutTests/platform/mac/fast/selectors/008-expected.txt View 1 chunk +0 lines, -19 lines 0 comments Download
D LayoutTests/platform/mac/fast/selectors/009-expected.png View Binary file 0 comments Download
D LayoutTests/platform/mac/fast/selectors/009-expected.txt View 1 chunk +0 lines, -11 lines 0 comments Download
D LayoutTests/platform/mac/fast/selectors/010-expected.png View Binary file 0 comments Download
D LayoutTests/platform/mac/fast/selectors/010-expected.txt View 1 chunk +0 lines, -8 lines 0 comments Download
D LayoutTests/platform/mac/fast/selectors/011-expected.png View Binary file 0 comments Download
D LayoutTests/platform/mac/fast/selectors/011-expected.txt View 1 chunk +0 lines, -8 lines 0 comments Download
D LayoutTests/platform/mac/fast/selectors/012-expected.png View Binary file 0 comments Download
D LayoutTests/platform/mac/fast/selectors/012-expected.txt View 1 chunk +0 lines, -10 lines 0 comments Download
D LayoutTests/platform/mac/fast/selectors/013-expected.png View Binary file 0 comments Download
D LayoutTests/platform/mac/fast/selectors/013-expected.txt View 1 chunk +0 lines, -21 lines 0 comments Download
D LayoutTests/platform/mac/fast/selectors/014-expected.png View Binary file 0 comments Download
D LayoutTests/platform/mac/fast/selectors/014-expected.txt View 1 chunk +0 lines, -10 lines 0 comments Download
D LayoutTests/platform/mac/fast/selectors/015-expected.png View Binary file 0 comments Download
D LayoutTests/platform/mac/fast/selectors/015-expected.txt View 1 chunk +0 lines, -19 lines 0 comments Download
D LayoutTests/platform/mac/fast/selectors/016-expected.png View Binary file 0 comments Download
D LayoutTests/platform/mac/fast/selectors/016-expected.txt View 1 chunk +0 lines, -11 lines 0 comments Download
D LayoutTests/platform/mac/fast/selectors/017-expected.png View Binary file 0 comments Download
D LayoutTests/platform/mac/fast/selectors/017-expected.txt View 1 chunk +0 lines, -10 lines 0 comments Download
D LayoutTests/platform/win-xp/fast/selectors/001-expected.png View Binary file 0 comments Download
D LayoutTests/platform/win-xp/fast/selectors/001-expected.txt View 1 chunk +0 lines, -17 lines 0 comments Download
D LayoutTests/platform/win-xp/fast/selectors/002-expected.png View Binary file 0 comments Download
D LayoutTests/platform/win-xp/fast/selectors/002-expected.txt View 1 chunk +0 lines, -8 lines 0 comments Download
D LayoutTests/platform/win-xp/fast/selectors/003-expected.png View Binary file 0 comments Download
D LayoutTests/platform/win-xp/fast/selectors/003-expected.txt View 1 chunk +0 lines, -8 lines 0 comments Download
D LayoutTests/platform/win-xp/fast/selectors/004-expected.png View Binary file 0 comments Download
D LayoutTests/platform/win-xp/fast/selectors/004-expected.txt View 1 chunk +0 lines, -9 lines 0 comments Download
D LayoutTests/platform/win-xp/fast/selectors/005-expected.png View Binary file 0 comments Download
D LayoutTests/platform/win-xp/fast/selectors/005-expected.txt View 1 chunk +0 lines, -9 lines 0 comments Download
D LayoutTests/platform/win-xp/fast/selectors/006-expected.png View Binary file 0 comments Download
D LayoutTests/platform/win-xp/fast/selectors/006-expected.txt View 1 chunk +0 lines, -15 lines 0 comments Download
D LayoutTests/platform/win-xp/fast/selectors/007a-expected.png View Binary file 0 comments Download
D LayoutTests/platform/win-xp/fast/selectors/007a-expected.txt View 1 chunk +0 lines, -20 lines 0 comments Download
D LayoutTests/platform/win-xp/fast/selectors/007b-expected.png View Binary file 0 comments Download
D LayoutTests/platform/win-xp/fast/selectors/007b-expected.txt View 1 chunk +0 lines, -8 lines 0 comments Download
D LayoutTests/platform/win-xp/fast/selectors/008-expected.png View Binary file 0 comments Download
D LayoutTests/platform/win-xp/fast/selectors/008-expected.txt View 1 chunk +0 lines, -19 lines 0 comments Download
D LayoutTests/platform/win-xp/fast/selectors/009-expected.png View Binary file 0 comments Download
D LayoutTests/platform/win-xp/fast/selectors/009-expected.txt View 1 chunk +0 lines, -11 lines 0 comments Download
D LayoutTests/platform/win-xp/fast/selectors/010-expected.png View Binary file 0 comments Download
D LayoutTests/platform/win-xp/fast/selectors/010-expected.txt View 1 chunk +0 lines, -8 lines 0 comments Download
D LayoutTests/platform/win-xp/fast/selectors/011-expected.png View Binary file 0 comments Download
D LayoutTests/platform/win-xp/fast/selectors/011-expected.txt View 1 chunk +0 lines, -8 lines 0 comments Download
D LayoutTests/platform/win-xp/fast/selectors/012-expected.png View Binary file 0 comments Download
D LayoutTests/platform/win-xp/fast/selectors/012-expected.txt View 1 chunk +0 lines, -10 lines 0 comments Download
D LayoutTests/platform/win-xp/fast/selectors/013-expected.png View Binary file 0 comments Download
D LayoutTests/platform/win-xp/fast/selectors/013-expected.txt View 1 chunk +0 lines, -21 lines 0 comments Download
D LayoutTests/platform/win-xp/fast/selectors/014-expected.png View Binary file 0 comments Download
D LayoutTests/platform/win-xp/fast/selectors/014-expected.txt View 1 chunk +0 lines, -9 lines 0 comments Download
D LayoutTests/platform/win-xp/fast/selectors/015-expected.png View Binary file 0 comments Download
D LayoutTests/platform/win-xp/fast/selectors/015-expected.txt View 1 chunk +0 lines, -19 lines 0 comments Download
D LayoutTests/platform/win-xp/fast/selectors/016-expected.png View Binary file 0 comments Download
D LayoutTests/platform/win-xp/fast/selectors/016-expected.txt View 1 chunk +0 lines, -11 lines 0 comments Download
D LayoutTests/platform/win-xp/fast/selectors/017-expected.png View Binary file 0 comments Download
D LayoutTests/platform/win-xp/fast/selectors/017-expected.txt View 1 chunk +0 lines, -10 lines 0 comments Download
D LayoutTests/platform/win/fast/selectors/001-expected.png View Binary file 0 comments Download
D LayoutTests/platform/win/fast/selectors/001-expected.txt View 1 chunk +0 lines, -17 lines 0 comments Download
D LayoutTests/platform/win/fast/selectors/002-expected.png View Binary file 0 comments Download
D LayoutTests/platform/win/fast/selectors/002-expected.txt View 1 chunk +0 lines, -8 lines 0 comments Download
D LayoutTests/platform/win/fast/selectors/003-expected.png View Binary file 0 comments Download
D LayoutTests/platform/win/fast/selectors/003-expected.txt View 1 chunk +0 lines, -8 lines 0 comments Download
D LayoutTests/platform/win/fast/selectors/004-expected.png View Binary file 0 comments Download
D LayoutTests/platform/win/fast/selectors/004-expected.txt View 1 chunk +0 lines, -9 lines 0 comments Download
D LayoutTests/platform/win/fast/selectors/005-expected.png View Binary file 0 comments Download
D LayoutTests/platform/win/fast/selectors/005-expected.txt View 1 chunk +0 lines, -9 lines 0 comments Download
D LayoutTests/platform/win/fast/selectors/006-expected.png View Binary file 0 comments Download
D LayoutTests/platform/win/fast/selectors/006-expected.txt View 1 chunk +0 lines, -15 lines 0 comments Download
D LayoutTests/platform/win/fast/selectors/007a-expected.png View Binary file 0 comments Download
D LayoutTests/platform/win/fast/selectors/007a-expected.txt View 1 chunk +0 lines, -20 lines 0 comments Download
D LayoutTests/platform/win/fast/selectors/007b-expected.png View Binary file 0 comments Download
D LayoutTests/platform/win/fast/selectors/007b-expected.txt View 1 chunk +0 lines, -8 lines 0 comments Download
D LayoutTests/platform/win/fast/selectors/008-expected.png View Binary file 0 comments Download
D LayoutTests/platform/win/fast/selectors/008-expected.txt View 1 chunk +0 lines, -19 lines 0 comments Download
D LayoutTests/platform/win/fast/selectors/009-expected.png View Binary file 0 comments Download
D LayoutTests/platform/win/fast/selectors/009-expected.txt View 1 chunk +0 lines, -11 lines 0 comments Download
D LayoutTests/platform/win/fast/selectors/010-expected.png View Binary file 0 comments Download
D LayoutTests/platform/win/fast/selectors/010-expected.txt View 1 chunk +0 lines, -8 lines 0 comments Download
D LayoutTests/platform/win/fast/selectors/011-expected.png View Binary file 0 comments Download
D LayoutTests/platform/win/fast/selectors/011-expected.txt View 1 chunk +0 lines, -8 lines 0 comments Download
D LayoutTests/platform/win/fast/selectors/012-expected.png View Binary file 0 comments Download
D LayoutTests/platform/win/fast/selectors/012-expected.txt View 1 chunk +0 lines, -10 lines 0 comments Download
D LayoutTests/platform/win/fast/selectors/013-expected.png View Binary file 0 comments Download
D LayoutTests/platform/win/fast/selectors/013-expected.txt View 1 chunk +0 lines, -21 lines 0 comments Download
D LayoutTests/platform/win/fast/selectors/014-expected.png View Binary file 0 comments Download
D LayoutTests/platform/win/fast/selectors/014-expected.txt View 1 chunk +0 lines, -10 lines 0 comments Download
D LayoutTests/platform/win/fast/selectors/015-expected.png View Binary file 0 comments Download
D LayoutTests/platform/win/fast/selectors/015-expected.txt View 1 chunk +0 lines, -19 lines 0 comments Download
D LayoutTests/platform/win/fast/selectors/016-expected.png View Binary file 0 comments Download
D LayoutTests/platform/win/fast/selectors/016-expected.txt View 1 chunk +0 lines, -11 lines 0 comments Download
D LayoutTests/platform/win/fast/selectors/017-expected.png View Binary file 0 comments Download
D LayoutTests/platform/win/fast/selectors/017-expected.txt View 1 chunk +0 lines, -10 lines 0 comments Download

Messages

Total messages: 12 (4 generated)
rune
5 years, 11 months ago (2015-01-13 08:20:21 UTC) #2
mstensho (USE GERRIT)
Only reviewed the first file in the patch set so far. https://codereview.chromium.org/847073002/diff/1/LayoutTests/fast/selectors/001-expected.html File LayoutTests/fast/selectors/001-expected.html (right): ...
5 years, 11 months ago (2015-01-13 09:24:18 UTC) #3
rune
https://codereview.chromium.org/847073002/diff/1/LayoutTests/fast/selectors/001-expected.html File LayoutTests/fast/selectors/001-expected.html (right): https://codereview.chromium.org/847073002/diff/1/LayoutTests/fast/selectors/001-expected.html#newcode1 LayoutTests/fast/selectors/001-expected.html:1: <!DOCTYPE html> On 2015/01/13 at 09:24:18, mstensho wrote: > ...
5 years, 11 months ago (2015-01-13 13:45:23 UTC) #4
mstensho (USE GERRIT)
lgtm
5 years, 11 months ago (2015-01-13 14:50:32 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/847073002/20001
5 years, 11 months ago (2015-01-13 14:55:24 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: mac_blink_rel on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/mac_blink_rel/builds/38531)
5 years, 11 months ago (2015-01-13 17:00:50 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/847073002/20001
5 years, 11 months ago (2015-01-13 17:28:48 UTC) #11
commit-bot: I haz the power
5 years, 11 months ago (2015-01-13 18:36:25 UTC) #12
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=188312

Powered by Google App Engine
This is Rietveld 408576698