Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(367)

Issue 847053002: Remove StyleEngine::usesFirstLineRules(). (Closed)

Created:
5 years, 11 months ago by esprehn
Modified:
5 years, 11 months ago
Reviewers:
ojan, abarth-chromium
CC:
abarth-chromium, mojo-reviews_chromium.org, ojan
Base URL:
git@github.com:domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Remove StyleEngine::usesFirstLineRules(). It always returns false, and Sky doesn't support first line rules. R=abarth@chromium.org, ojan@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/189cab03f69160e7a93ecdbd58ae8c4407f1ea5e

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -25 lines) Patch
M sky/engine/core/dom/StyleEngine.h View 1 chunk +0 lines, -3 lines 0 comments Download
M sky/engine/core/rendering/RenderBlock.cpp View 1 chunk +1 line, -3 lines 0 comments Download
M sky/engine/core/rendering/RenderInline.cpp View 2 chunks +0 lines, -15 lines 0 comments Download
M sky/engine/core/rendering/RootInlineBox.cpp View 1 chunk +1 line, -4 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
esprehn
5 years, 11 months ago (2015-01-13 06:29:17 UTC) #1
abarth-chromium
lgtm
5 years, 11 months ago (2015-01-13 07:17:04 UTC) #3
esprehn
5 years, 11 months ago (2015-01-13 07:32:32 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
189cab03f69160e7a93ecdbd58ae8c4407f1ea5e (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698