Issue 847033002: Revert of Fix GPU clipped-AA vs. non-AA drawRect discrepancy

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 847033002: Revert of Fix GPU clipped-AA vs. non-AA drawRect discrepancy (Closed)

Created:
5 years, 11 months ago by robertphillips

Modified:
5 years, 11 months ago

Reviewers:
jvanverth1, bsalomon

CC:
reviews_skia.org

Base URL:
https://skia.googlesource.com/skia.git@master

Target Ref:
refs/heads/master

Project:
skia

Visibility:
Public.

Revert of Fix GPU clipped-AA vs. non-AA drawRect discrepancy (patchset #2 id:20001 of https://codereview.chromium.org/839883003/) Reason for revert: This CL introduces rendering conflicts with hairlines (i.e., the hairlines get overwritten). These conflicts are particularly visible on the following GMs (for the Ubuntu and Android gpu configs): coloremoji & complexclip2_rrect_bw Original issue's description: > Fix GPU clipped-AA vs. non-AA drawRect discrepancy > > In the clip stack we were manually rounding out non-AA clip rects but leaving the hardening of non-AA drawRects up to the GPU. In some border cases the GPU can truncate rather than round out resulting in visual discrepancies. > > BUG=423834 > > Committed: https://skia.googlesource.com/skia/+/933a03fecb65c83f81cf65d5cf9870c69aa379ff TBR=bsalomon@google.com,jvanverth@google.com NOTREECHECKS=true NOTRY=true BUG=423834 Committed: https://skia.googlesource.com/skia/+/125ee60ed3e510b1b9cbbaae8efdef2df5542ac1

Created: 5 years, 11 months ago

(Patch set is too large to download)

	Unified diffs	Side-by-side diffs	Stats (+13 lines, -102 lines)			Patch
M	expectations/gm/ignored-tests.txt	View	1 chunk	+0 lines, -9 lines	0 comments	Download
D	gm/clipdrawdraw.cpp	View	1 chunk	+0 lines, -92 lines	0 comments	Download
M	gyp/gmslides.gypi	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	src/core/SkClipStack.cpp	View	1 chunk	+13 lines, -0 lines	0 comments	Download

Total messages: 3 (0 generated)

robertphillips

Created Revert of Fix GPU clipped-AA vs. non-AA drawRect discrepancy

5 years, 11 months ago (2015-01-13 02:25:13 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/847033002/1

5 years, 11 months ago (2015-01-13 02:25:53 UTC) #2

commit-bot: I haz the power

5 years, 11 months ago (2015-01-13 02:26:05 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/125ee60ed3e510b1b9cbbaae8efdef2df5542ac1