Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2821)

Unified Diff: content/renderer/render_view_impl.cc

Issue 84703003: Allow data URL > 2MB for loadDataWithBaseURL (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Bo comments Created 7 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/renderer/render_view_impl.cc
diff --git a/content/renderer/render_view_impl.cc b/content/renderer/render_view_impl.cc
index fe683d5f99680b4e204cbda0445d74b7464f8de6..bdf6d3fed4a4755f98a366c3b3a054c66ed5ec35 100644
--- a/content/renderer/render_view_impl.cc
+++ b/content/renderer/render_view_impl.cc
@@ -1593,10 +1593,12 @@ void RenderViewImpl::OnNavigate(const ViewMsg_Navigate_Params& params) {
}
} else if (!params.base_url_for_data_url.is_empty()) {
// A loadData request with a specified base URL.
- std::string mime_type, charset, data;
- if (net::DataURL::Parse(params.url, &mime_type, &charset, &data)) {
+ std::string mime_type, charset;
+ if (net::DataURL::Parse(params.url, &mime_type, &charset, NULL)) {
+ base::StringPiece data(base::RefCountedMemory::AsString(
+ params.data_for_data_url.get()));
frame->loadData(
- WebData(data.c_str(), data.length()),
+ WebData(data.data(), data.size()),
WebString::fromUTF8(mime_type),
WebString::fromUTF8(charset),
params.base_url_for_data_url,

Powered by Google App Engine
This is Rietveld 408576698