Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3015)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/preferences/autofill/AutofillPreferences.java

Issue 847023002: Changes to android autofill preferences for wallet integration (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: its own page Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/java/src/org/chromium/chrome/browser/preferences/autofill/AutofillPreferences.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/preferences/autofill/AutofillPreferences.java b/chrome/android/java/src/org/chromium/chrome/browser/preferences/autofill/AutofillPreferences.java
index a6fb485f7ad3b4432caf5b0fef5203001dd03d5e..eb412f24721ef1d731be94c3bd246c7be711b3ec 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/preferences/autofill/AutofillPreferences.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/preferences/autofill/AutofillPreferences.java
@@ -18,6 +18,7 @@ import org.chromium.chrome.R;
import org.chromium.chrome.browser.autofill.PersonalDataManager;
import org.chromium.chrome.browser.autofill.PersonalDataManager.AutofillProfile;
import org.chromium.chrome.browser.autofill.PersonalDataManager.CreditCard;
+import org.chromium.chrome.browser.preferences.ChromeBasePreference;
import org.chromium.chrome.browser.preferences.ChromeSwitchPreference;
/**
@@ -34,6 +35,7 @@ public class AutofillPreferences extends PreferenceFragment
private static final String PREF_AUTOFILL_SWITCH = "autofill_switch";
private static final String PREF_AUTOFILL_PROFILES = "autofill_profiles";
private static final String PREF_AUTOFILL_CREDIT_CARDS = "autofill_credit_cards";
+ private static final String PREF_AUTOFILL_WALLET = "autofill_wallet";
@Override
public void onCreate(Bundle savedInstanceState) {
@@ -55,6 +57,14 @@ public class AutofillPreferences extends PreferenceFragment
}
});
+ ChromeBasePreference walletPref =
newt (away) 2015/01/14 02:04:53 can walletPref be managed by policy?
Evan Stade 2015/01/14 22:26:43 Well, it doesn't exist yet, so this is an open que
+ (ChromeBasePreference) findPreference(PREF_AUTOFILL_WALLET);
+ walletPref.setSummary(getResources().getString(PersonalDataManager.isWalletImportEnabled()
+ ? R.string.text_on
+ : R.string.text_off));
+ if (!PersonalDataManager.isWalletImportFeatureAvailable())
newt (away) 2015/01/14 02:04:53 curly braces. Also, I'd make this an if-else state
Evan Stade 2015/01/14 22:26:43 Done.
+ getPreferenceScreen().removePreference(walletPref);
+
setPreferenceCategoryIcons();
}

Powered by Google App Engine
This is Rietveld 408576698