Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(15)

Unified Diff: pkg/analyzer/lib/src/generated/engine.dart

Issue 846973002: Reset compilation unit in notification, as it might be damaged. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/analyzer/lib/src/generated/engine.dart
diff --git a/pkg/analyzer/lib/src/generated/engine.dart b/pkg/analyzer/lib/src/generated/engine.dart
index 379ada4b5bacbaf96f77572081d0929f70f0fbaf..6de1fb5daf5e73956db825e894b82708fd2581fd 100644
--- a/pkg/analyzer/lib/src/generated/engine.dart
+++ b/pkg/analyzer/lib/src/generated/engine.dart
@@ -5022,7 +5022,10 @@ class AnalysisContextImpl implements InternalAnalysisContext {
AnalysisPerformanceKind.INCREMENTAL,
perfCounter,
'success=$success,context_id=$_id,code_length=${newCode.length}');
+ // if failed, reset compilation unit in notification, it is damaged now
if (!success) {
+ ChangeNoticeImpl notice = _getNotice(unitSource);
+ notice.compilationUnit = null;
Brian Wilkerson 2015/01/12 22:37:02 Is the compilation unit in the cache marked as inv
return false;
}
// if validation, remember the result, but throw it away
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698