Issue 846953002: Work around MSVC bug 1085387.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 846953002: Work around MSVC bug 1085387. (Closed)

Created:
5 years, 11 months ago by JF

Modified:
5 years, 11 months ago

Reviewers:
Derek Schuff

CC:
native-client-reviews_googlegroups.com

Base URL:
https://chromium.googlesource.com/native_client/pnacl-llvm.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

Work around MSVC bug 1085387. Work around the following bug: https://connect.microsoft.com/VisualStudio/feedback/details/1085387 Patched in Emscripten by juj: https://github.com/kripken/emscripten-fastcomp/pull/61 Discussed fixing differently with clb on Emscripten's IRC channel. My previous patch didn't quite do the right thing: I also needed to remove the ::. R=dschuff@chromium.org TEST= build with MSVC BUG= doesn't build with MSVC Committed: https://gerrit.chromium.org/gerrit/gitweb?p=native_client/pnacl-llvm.git;a=commit;h=f00ec881e18034e36719101e38b0795cd34b6615

Created: 5 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	lib/Transforms/NaCl/FlattenGlobals.cpp	View		1 chunk	+1 line, -1 line	0 comments	Download

Total messages: 3 (0 generated)

5 years, 11 months ago (2015-01-12 19:29:42 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
f00ec881e18034e36719101e38b0795cd34b6615 (presubmit successful).