Source/core/css/StylePropertySerializer.cpp - Issue 846933002: Handle null in value list in getLayeredShorthandValue

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/css/StylePropertySerializer.cpp

Issue 846933002: Handle null in value list in getLayeredShorthandValue (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Fix more tests Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/core/css/StylePropertySerializer.cpp

diff --git a/Source/core/css/StylePropertySerializer.cpp b/Source/core/css/StylePropertySerializer.cpp

index 0e249bd4de19ba7f58c4787ce8e585b9d33826b4..d59e764ef6661f0c71257e8687ac2cc077ed1ef7 100644

--- a/Source/core/css/StylePropertySerializer.cpp

+++ b/Source/core/css/StylePropertySerializer.cpp

@@ -401,7 +401,7 @@ String StylePropertySerializer::getPropertyValue(CSSPropertyID propertyID) const

case CSSPropertyBackgroundRepeat:

return backgroundRepeatPropertyValue();

case CSSPropertyBackground:

- return getLayeredShorthandValue(backgroundShorthand());

+ return getLayeredShorthandValue(backgroundShorthand(), true);

case CSSPropertyBorder:

return borderPropertyValue(OmitUncommonValues);

case CSSPropertyBorderTop:

« no previous file with comments | « LayoutTests/fast/dom/background-shorthand-csstext-expected.txt ('k') | no next file » | no next file with comments »