Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(768)

Issue 846913002: [turbofan] Canonicalize x - K to x + -K. (Closed)

Created:
5 years, 11 months ago by Benedikt Meurer
Modified:
5 years, 11 months ago
Reviewers:
dcarney
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Canonicalize x - K to x + -K. TEST=unittests R=dcarney@chromium.org Committed: https://crrev.com/0e8a6d4ec88e0d29f2565bf6099f67a032ff5a8a Cr-Commit-Position: refs/heads/master@{#26027}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+44 lines, -11 lines) Patch
M src/compiler/machine-operator-reducer.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/compiler/machine-operator-reducer.cc View 3 chunks +24 lines, -11 lines 0 comments Download
M test/unittests/compiler/machine-operator-reducer-unittest.cc View 1 chunk +19 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
Benedikt Meurer
5 years, 11 months ago (2015-01-12 14:33:01 UTC) #1
dcarney
lgtm
5 years, 11 months ago (2015-01-12 14:34:51 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/846913002/1
5 years, 11 months ago (2015-01-12 14:35:13 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 11 months ago (2015-01-12 15:02:04 UTC) #5
commit-bot: I haz the power
5 years, 11 months ago (2015-01-12 15:02:19 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/0e8a6d4ec88e0d29f2565bf6099f67a032ff5a8a
Cr-Commit-Position: refs/heads/master@{#26027}

Powered by Google App Engine
This is Rietveld 408576698