Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(275)

Side by Side Diff: chrome/browser/chromeos/frame/bubble_window.h

Issue 8469006: Promote bubble_window_style to more general dialog_style. (Closed) Base URL: /usr/local/google/home/bshe/NoTouchChromium/../TouchChromium/src/@trunk
Patch Set: Change base url and merge trunk. Created 9 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2011 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_CHROMEOS_FRAME_BUBBLE_WINDOW_H_ 5 #ifndef CHROME_BROWSER_CHROMEOS_FRAME_BUBBLE_WINDOW_H_
6 #define CHROME_BROWSER_CHROMEOS_FRAME_BUBBLE_WINDOW_H_ 6 #define CHROME_BROWSER_CHROMEOS_FRAME_BUBBLE_WINDOW_H_
7 #pragma once 7 #pragma once
8 8
9 #include "chrome/browser/chromeos/frame/bubble_window_style.h" 9 #include "chrome/browser/chromeos/frame/bubble_window_style.h"
10 #include "chrome/browser/ui/dialog_style.h"
10 11
11 #if defined(TOOLKIT_USES_GTK) 12 #if defined(TOOLKIT_USES_GTK)
12 // TODO(msw): While I dislike the includes and code to be mixed into the same 13 // TODO(msw): While I dislike the includes and code to be mixed into the same
13 // preprocessor conditional, this seems okay as I can hopefully fix this up 14 // preprocessor conditional, this seems okay as I can hopefully fix this up
14 // in a matter of days / crbug.com/98322. 15 // in a matter of days / crbug.com/98322.
15 #include "views/widget/native_widget_gtk.h" 16 #include "views/widget/native_widget_gtk.h"
16 #else // TOOLKIT_USES_GTK 17 #else // TOOLKIT_USES_GTK
17 #include "views/view.h" 18 #include "views/view.h"
18 #endif 19 #endif
19 20
20 namespace views { 21 namespace views {
21 class WidgetDelegate; 22 class WidgetDelegate;
22 } 23 }
23 24
24 #if defined(TOOLKIT_USES_GTK) 25 #if defined(TOOLKIT_USES_GTK)
25 // TODO(msw): To fix as explained above (crbug.com/98322). 26 // TODO(msw): To fix as explained above (crbug.com/98322).
26 namespace chromeos { 27 namespace chromeos {
27 28
28 // A window that uses BubbleFrameView as its frame. 29 // A window that uses BubbleFrameView as its frame.
29 class BubbleWindow : public views::NativeWidgetGtk { 30 class BubbleWindow : public views::NativeWidgetGtk {
30 public: 31 public:
31 static views::Widget* Create(gfx::NativeWindow parent, 32 static views::Widget* Create(gfx::NativeWindow parent,
32 BubbleWindowStyle style, 33 DialogStyle style,
33 views::WidgetDelegate* widget_delegate); 34 views::WidgetDelegate* widget_delegate);
34 35
35 protected: 36 protected:
36 BubbleWindow(views::Widget* window, BubbleWindowStyle style); 37 BubbleWindow(views::Widget* window, DialogStyle style);
37 38
38 // Overridden from views::NativeWidgetGtk: 39 // Overridden from views::NativeWidgetGtk:
39 virtual void InitNativeWidget( 40 virtual void InitNativeWidget(
40 const views::Widget::InitParams& params) OVERRIDE; 41 const views::Widget::InitParams& params) OVERRIDE;
41 virtual views::NonClientFrameView* CreateNonClientFrameView() OVERRIDE; 42 virtual views::NonClientFrameView* CreateNonClientFrameView() OVERRIDE;
42 43
43 private: 44 private:
44 BubbleWindowStyle style_; 45 DialogStyle style_;
45 46
46 DISALLOW_COPY_AND_ASSIGN(BubbleWindow); 47 DISALLOW_COPY_AND_ASSIGN(BubbleWindow);
47 }; 48 };
48 49
49 } // namespace chromeos 50 } // namespace chromeos
50 51
51 #else // TOOLKIT_USES_GTK 52 #else // TOOLKIT_USES_GTK
52 53
53 namespace chromeos { 54 namespace chromeos {
54 55
55 class BubbleWindow { 56 class BubbleWindow {
56 public: 57 public:
57 static views::Widget* Create(gfx::NativeWindow parent, 58 static views::Widget* Create(gfx::NativeWindow parent,
58 BubbleWindowStyle style, 59 DialogStyle style,
59 views::WidgetDelegate* widget_delegate) { 60 views::WidgetDelegate* widget_delegate) {
60 NOTIMPLEMENTED(); 61 NOTIMPLEMENTED();
61 return NULL; 62 return NULL;
62 } 63 }
63 }; 64 };
64 65
65 } // namespace chromeos 66 } // namespace chromeos
66 67
67 #endif // TOOLKIT_USES_GTK 68 #endif // TOOLKIT_USES_GTK
68 69
69 #endif // CHROME_BROWSER_CHROMEOS_FRAME_BUBBLE_WINDOW_H_ 70 #endif // CHROME_BROWSER_CHROMEOS_FRAME_BUBBLE_WINDOW_H_
OLDNEW
« no previous file with comments | « chrome/browser/chromeos/frame/bubble_frame_view.cc ('k') | chrome/browser/chromeos/frame/bubble_window_gtk.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698