Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(983)

Issue 846853003: views::Label: Invalidate cached draw flags when background color is changed (Closed)

Created:
5 years, 11 months ago by ckocagil
Modified:
5 years, 11 months ago
Reviewers:
sky
CC:
chromium-reviews, tfarina
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

views::Label: Invalidate cached draw flags when background color is changed Transparency of the background color affects the result of |Label::ComputeDrawStringFlags()|. BUG=447932 R=sky NOTRY=true Committed: https://crrev.com/8b51af8017e02cb46a17bff0980bebf973a23790 Cr-Commit-Position: refs/heads/master@{#311088}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M ui/views/controls/label.cc View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
ckocagil
5 years, 11 months ago (2015-01-12 12:08:15 UTC) #1
sky
LGTM
5 years, 11 months ago (2015-01-12 17:00:55 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/846853003/1
5 years, 11 months ago (2015-01-12 17:18:31 UTC) #4
commit-bot: I haz the power
Try jobs failed on following builders: ios_dbg_simulator on tryserver.chromium.mac (http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator/builds/48025)
5 years, 11 months ago (2015-01-12 17:23:31 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/846853003/1
5 years, 11 months ago (2015-01-12 19:47:48 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 11 months ago (2015-01-12 19:49:00 UTC) #9
commit-bot: I haz the power
5 years, 11 months ago (2015-01-12 19:50:29 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/8b51af8017e02cb46a17bff0980bebf973a23790
Cr-Commit-Position: refs/heads/master@{#311088}

Powered by Google App Engine
This is Rietveld 408576698