Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(109)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 846813002: Revert "Remove impl-side-painting from about:flags" (Closed)

Created:
5 years, 11 months ago by f(malita)
Modified:
5 years, 11 months ago
Reviewers:
danakj
CC:
chromium-reviews, mlamouri+watch-content_chromium.org, nasko+codewatch_chromium.org, creis+watch_chromium.org, nkostylev+watch_chromium.org, dzhioev+watch_chromium.org, jam, darin-cc_chromium.org, oshima+watch_chromium.org, mkwst+moarreviews-renderer_chromium.org, piman+watch_chromium.org, stevenjb+watch_chromium.org, android-webview-reviews_chromium.org, davemoore+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert "Remove impl-side-painting from about:flags" This reverts commit c138f5dd7e317f141edf0e2f87a74c487174c172. Broke 2000+ layout tests (enabled content_shell impl-side painting globally?). BUG=169282 TBR=danakj@chromium.org NOTRY=true Committed: https://crrev.com/56280c0b843f01f15ceba3cb952eb937b9cff198 Cr-Commit-Position: refs/heads/master@{#310990}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+31 lines, -12 lines) Patch
M android_webview/lib/main/aw_main_delegate.cc View 1 chunk +1 line, -0 lines 0 comments Download
M build/ios/grit_whitelist.txt View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/app/generated_resources.grd View 1 chunk +6 lines, -0 lines 0 comments Download
M chrome/browser/about_flags.cc View 1 chunk +8 lines, -0 lines 0 comments Download
M chrome/browser/chromeos/login/chrome_restart_request.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/common/crash_keys.cc View 1 chunk +1 line, -0 lines 0 comments Download
M content/browser/gpu/compositor_util.cc View 1 chunk +5 lines, -1 line 0 comments Download
M content/browser/renderer_host/render_process_host_impl.cc View 1 chunk +1 line, -2 lines 0 comments Download
M content/public/common/content_switches.h View 1 chunk +1 line, -0 lines 0 comments Download
M content/public/common/content_switches.cc View 2 chunks +4 lines, -0 lines 0 comments Download
M content/renderer/render_thread_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/render_thread_impl_browsertest.cc View 1 chunk +0 lines, -8 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/846813002/1
5 years, 11 months ago (2015-01-10 19:30:01 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 11 months ago (2015-01-10 19:30:59 UTC) #3
commit-bot: I haz the power
5 years, 11 months ago (2015-01-10 19:31:56 UTC) #4
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/56280c0b843f01f15ceba3cb952eb937b9cff198
Cr-Commit-Position: refs/heads/master@{#310990}

Powered by Google App Engine
This is Rietveld 408576698