Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(255)

Issue 846783003: Add PointerEvent interface to Sky (Closed)

Created:
5 years, 11 months ago by abarth-chromium
Modified:
5 years, 11 months ago
Reviewers:
esprehn
CC:
esprehn, eseidel, mojo-reviews_chromium.org, ojan
Base URL:
git@github.com:domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Add PointerEvent interface to Sky Currently this interface is constructable from script but isn't used internally by the engine. R=esprehn@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/a164d47e0b7280c349b6a192fd02bb153dc33260

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+210 lines, -12 lines) Patch
M sky/engine/core/core.gni View 3 chunks +4 lines, -0 lines 0 comments Download
M sky/engine/core/events/Event.h View 1 chunk +4 lines, -5 lines 0 comments Download
M sky/engine/core/events/Event.cpp View 1 chunk +0 lines, -7 lines 0 comments Download
A sky/engine/core/events/PointerEvent.h View 1 chunk +106 lines, -0 lines 0 comments Download
A sky/engine/core/events/PointerEvent.cpp View 1 chunk +45 lines, -0 lines 0 comments Download
A sky/engine/core/events/PointerEvent.idl View 1 chunk +30 lines, -0 lines 0 comments Download
A sky/tests/events/pointer-events.sky View 1 chunk +16 lines, -0 lines 0 comments Download
A sky/tests/events/pointer-events-expected.txt View 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
abarth-chromium
5 years, 11 months ago (2015-01-16 08:05:05 UTC) #1
esprehn
lgtm
5 years, 11 months ago (2015-01-16 20:24:52 UTC) #2
abarth-chromium
5 years, 11 months ago (2015-01-16 23:36:03 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
a164d47e0b7280c349b6a192fd02bb153dc33260 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698