Update EnsureProcessGetsReaped to receive a pid.

Update EnsureProcessGetsReaped to receive a pid.

Related code is also being updated to the new version of LaunchProcess.

BUG=417532
Committed: https://crrev.com/c7b523fabeb26af57d78d5254ace208bf6ed2310
Cr-Commit-Position: refs/heads/master@{#311382}

[rvargas (doing something else), 2015-01-10 02:30:09]

rvargas@chromium.org changed reviewers:
+ jln@chromium.org, thestig@chromium.org

[rvargas (doing something else), 2015-01-10 02:30:10]

jln -> zygote_host
thestig -> base / chrome

[Lei Zhang, 2015-01-10 02:40:31]

lgtm

[rvargas (doing something else), 2015-01-13 19:06:03]

ping jnl

[rvargas (doing something else), 2015-01-13 19:06:36]

On 2015/01/13 19:06:03, rvargas wrote:
> ping jnl

(jln)

[jln (very slow on Chromium), 2015-01-13 19:19:23]

lgtm, sorry for the delay

https://chromiumcodereview.appspot.com/846753002/diff/1/content/browser/zygot...
File content/browser/zygote_host/zygote_host_impl_linux.cc (right):

https://chromiumcodereview.appspot.com/846753002/diff/1/content/browser/zygot...
content/browser/zygote_host/zygote_host_impl_linux.cc:196: // Note that
~base::Process() will reset the internal value, but there's no
Feel free to keep, but this confused me a little.
Isn't this captured entirely by the fact that pid_ is not a reference?

[rvargas (doing something else), 2015-01-13 19:37:04]

Thanks!

https://chromiumcodereview.appspot.com/846753002/diff/1/content/browser/zygot...
File content/browser/zygote_host/zygote_host_impl_linux.cc (right):

https://chromiumcodereview.appspot.com/846753002/diff/1/content/browser/zygot...
content/browser/zygote_host/zygote_host_impl_linux.cc:196: // Note that
~base::Process() will reset the internal value, but there's no
On 2015/01/13 19:19:23, jln wrote:
> Feel free to keep, but this confused me a little.
> Isn't this captured entirely by the fact that pid_ is not a reference?

The pattern
{
   ScopedFoo foo = Bar();
   foo_ = foo.get();
}

generally introduces a bug. I'm just trying to explain why it is OK to do that
in this particular case (it would be a bug if this code were platform
independent).

Suggestions for better wording are welcome :)

[rvargas (doing something else), 2015-01-14 00:30:10]

The CQ bit was checked by rvargas@chromium.org

[commit-bot: I haz the power, 2015-01-14 00:30:54]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/846753002/1

[commit-bot: I haz the power, 2015-01-14 01:14:03]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2015-01-14 01:14:44]

Patchset 1 (id:??) landed as
https://crrev.com/c7b523fabeb26af57d78d5254ace208bf6ed2310
Cr-Commit-Position: refs/heads/master@{#311382}