Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1321)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 846743004: Add d8 target to BUILD.gn (Closed)

Created:
5 years, 11 months ago by jochen (gone - plz use gerrit)
Modified:
5 years, 11 months ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Add d8 target to BUILD.gn R=machenbach@chromium.org,brettw@chromium.org LOG=n BUG=none Committed: https://crrev.com/778c6f7fd7c1aa9680180dad5d44af7a3158b94e Cr-Commit-Position: refs/heads/master@{#26151}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+62 lines, -0 lines) Patch
M BUILD.gn View 3 chunks +62 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (1 generated)
jochen (gone - plz use gerrit)
5 years, 11 months ago (2015-01-20 10:44:07 UTC) #1
jochen (gone - plz use gerrit)
i checked android compilation locally.
5 years, 11 months ago (2015-01-20 10:44:40 UTC) #2
Michael Achenbach
lgtm (rubber-stamp)
5 years, 11 months ago (2015-01-20 10:52:58 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/846743004/1
5 years, 11 months ago (2015-01-20 10:55:07 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 11 months ago (2015-01-20 11:31:52 UTC) #6
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/778c6f7fd7c1aa9680180dad5d44af7a3158b94e Cr-Commit-Position: refs/heads/master@{#26151}
5 years, 11 months ago (2015-01-20 11:32:07 UTC) #7
brettw
5 years, 11 months ago (2015-01-20 18:45:06 UTC) #8
Message was sent while issue was closed. 
LGTM, thanks!

Powered by Google App Engine
This is Rietveld 408576698