Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(361)

Issue 84673002: Deinline the implementation of StdStringCanonOutput. (Closed)

Created:
7 years ago by tfarina
Modified:
7 years ago
Reviewers:
Nico, abarth-chromium
CC:
chromium-reviews
Visibility:
Public.

Description

Deinline the implementation of StdStringCanonOutput. This should move the implementation of StdStringCanonOutput from the header to the source file, that should please the chromium-style clang plugin. BUG=287029 TEST=url_unittests R=thakis@chromium.org,abarth@chromium.org TBR=abarth Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=238392

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+39 lines, -21 lines) Patch
M url/url.gyp View 1 chunk +1 line, -0 lines 0 comments Download
M url/url_canon_stdstring.h View 2 chunks +6 lines, -21 lines 0 comments Download
A url/url_canon_stdstring.cc View 1 chunk +32 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
tfarina
Hi Nico, could you review this to me? Adam, for rubber stamp when Nico is ...
7 years ago (2013-11-24 17:38:20 UTC) #1
Nico
lgtm
7 years ago (2013-11-27 03:12:27 UTC) #2
tfarina
pushing the trigger...
7 years ago (2013-12-03 01:38:22 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tfarina@chromium.org/84673002/1
7 years ago (2013-12-03 01:38:36 UTC) #4
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) browser_tests, chrome_frame_net_tests, chrome_frame_tests, chrome_frame_unittests, content_browsertests, content_unittests, ...
7 years ago (2013-12-03 04:17:49 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tfarina@chromium.org/84673002/1
7 years ago (2013-12-03 12:58:07 UTC) #6
commit-bot: I haz the power
7 years ago (2013-12-03 14:31:23 UTC) #7
Message was sent while issue was closed.
Change committed as 238392

Powered by Google App Engine
This is Rietveld 408576698