Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(207)

Side by Side Diff: base/tracking_info.h

Issue 846663002: Use ThreadData::Now() for TrackingInfo::time_posted initialization (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Remove unnecessary expectation Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « base/tracked_objects_unittest.cc ('k') | base/tracking_info.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 // This is a simple struct with tracking information that is stored 5 // This is a simple struct with tracking information that is stored
6 // with a PendingTask (when message_loop is handling the task). 6 // with a PendingTask (when message_loop is handling the task).
7 // Only the information that is shared with the profiler in tracked_objects 7 // Only the information that is shared with the profiler in tracked_objects
8 // are included in this structure. 8 // are included in this structure.
9 9
10 10
(...skipping 18 matching lines...) Expand all
29 base::TimeTicks delayed_run_time); 29 base::TimeTicks delayed_run_time);
30 ~TrackingInfo(); 30 ~TrackingInfo();
31 31
32 // To avoid conflating our stats with the delay duration in a PostDelayedTask, 32 // To avoid conflating our stats with the delay duration in a PostDelayedTask,
33 // we identify such tasks, and replace their post_time with the time they 33 // we identify such tasks, and replace their post_time with the time they
34 // were scheduled (requested?) to emerge from the delayed task queue. This 34 // were scheduled (requested?) to emerge from the delayed task queue. This
35 // means that queuing delay for such tasks will show how long they went 35 // means that queuing delay for such tasks will show how long they went
36 // unserviced, after they *could* be serviced. This is the same stat as we 36 // unserviced, after they *could* be serviced. This is the same stat as we
37 // have for non-delayed tasks, and we consistently call it queuing delay. 37 // have for non-delayed tasks, and we consistently call it queuing delay.
38 tracked_objects::TrackedTime EffectiveTimePosted() const { 38 tracked_objects::TrackedTime EffectiveTimePosted() const {
39 return tracked_objects::TrackedTime( 39 return delayed_run_time.is_null()
40 delayed_run_time.is_null() ? time_posted : delayed_run_time); 40 ? time_posted
41 : tracked_objects::TrackedTime(delayed_run_time);
41 } 42 }
42 43
43 // Record of location and thread that the task came from. 44 // Record of location and thread that the task came from.
44 tracked_objects::Births* birth_tally; 45 tracked_objects::Births* birth_tally;
45 46
46 // Time when the related task was posted. 47 // Time when the related task was posted. Note that this value may be empty
47 base::TimeTicks time_posted; 48 // if task profiling is disabled, and should only be used in conjunction with
49 // profiling-related reporting.
50 tracked_objects::TrackedTime time_posted;
48 51
49 // The time when the task should be run. 52 // The time when the task should be run.
50 base::TimeTicks delayed_run_time; 53 base::TimeTicks delayed_run_time;
51 }; 54 };
52 55
53 } // namespace base 56 } // namespace base
54 57
55 #endif // BASE_TRACKING_INFO_H_ 58 #endif // BASE_TRACKING_INFO_H_
OLDNEW
« no previous file with comments | « base/tracked_objects_unittest.cc ('k') | base/tracking_info.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698