Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(76)

Side by Side Diff: base/message_loop/message_loop_unittest.cc

Issue 846663002: Use ThreadData::Now() for TrackingInfo::time_posted initialization (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Remove unnecessary expectation Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | base/threading/worker_pool_posix.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include <vector> 5 #include <vector>
6 6
7 #include "base/bind.h" 7 #include "base/bind.h"
8 #include "base/bind_helpers.h" 8 #include "base/bind_helpers.h"
9 #include "base/compiler_specific.h" 9 #include "base/compiler_specific.h"
10 #include "base/logging.h" 10 #include "base/logging.h"
(...skipping 650 matching lines...) Expand 10 before | Expand all | Expand 10 after
661 public: 661 public:
662 explicit DummyTaskObserver(int num_tasks) 662 explicit DummyTaskObserver(int num_tasks)
663 : num_tasks_started_(0), 663 : num_tasks_started_(0),
664 num_tasks_processed_(0), 664 num_tasks_processed_(0),
665 num_tasks_(num_tasks) {} 665 num_tasks_(num_tasks) {}
666 666
667 ~DummyTaskObserver() override {} 667 ~DummyTaskObserver() override {}
668 668
669 void WillProcessTask(const PendingTask& pending_task) override { 669 void WillProcessTask(const PendingTask& pending_task) override {
670 num_tasks_started_++; 670 num_tasks_started_++;
671 EXPECT_TRUE(pending_task.time_posted != TimeTicks());
672 EXPECT_LE(num_tasks_started_, num_tasks_); 671 EXPECT_LE(num_tasks_started_, num_tasks_);
673 EXPECT_EQ(num_tasks_started_, num_tasks_processed_ + 1); 672 EXPECT_EQ(num_tasks_started_, num_tasks_processed_ + 1);
674 } 673 }
675 674
676 void DidProcessTask(const PendingTask& pending_task) override { 675 void DidProcessTask(const PendingTask& pending_task) override {
677 num_tasks_processed_++; 676 num_tasks_processed_++;
678 EXPECT_TRUE(pending_task.time_posted != TimeTicks());
679 EXPECT_LE(num_tasks_started_, num_tasks_); 677 EXPECT_LE(num_tasks_started_, num_tasks_);
680 EXPECT_EQ(num_tasks_started_, num_tasks_processed_); 678 EXPECT_EQ(num_tasks_started_, num_tasks_processed_);
681 } 679 }
682 680
683 int num_tasks_started() const { return num_tasks_started_; } 681 int num_tasks_started() const { return num_tasks_started_; }
684 int num_tasks_processed() const { return num_tasks_processed_; } 682 int num_tasks_processed() const { return num_tasks_processed_; }
685 683
686 private: 684 private:
687 int num_tasks_started_; 685 int num_tasks_started_;
688 int num_tasks_processed_; 686 int num_tasks_processed_;
(...skipping 318 matching lines...) Expand 10 before | Expand all | Expand 10 after
1007 1005
1008 ASSERT_TRUE(PostMessage(message_hwnd, kSignalMsg, 0, 1)); 1006 ASSERT_TRUE(PostMessage(message_hwnd, kSignalMsg, 0, 1));
1009 1007
1010 loop.Run(); 1008 loop.Run();
1011 1009
1012 ASSERT_TRUE(UnregisterClass(MAKEINTATOM(atom), instance)); 1010 ASSERT_TRUE(UnregisterClass(MAKEINTATOM(atom), instance));
1013 } 1011 }
1014 #endif // defined(OS_WIN) 1012 #endif // defined(OS_WIN)
1015 1013
1016 } // namespace base 1014 } // namespace base
OLDNEW
« no previous file with comments | « no previous file | base/threading/worker_pool_posix.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698