Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(347)

Issue 846653002: Introduce a gyp variable to control whether or not slow dchecks are on (Closed)

Created:
5 years, 11 months ago by jochen (gone - plz use gerrit)
Modified:
5 years, 11 months ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Introduce a gyp variable to control whether or not slow dchecks are on The default for the various debug modes doesn't change. In a follow-up, OptDebug1 and OptDebug2 will be merged R=machenbach@chromium.org LOG=y BUG=none Committed: https://crrev.com/77e3e48ee23cccc990f82e1e744da2ad045002f1 Cr-Commit-Position: refs/heads/master@{#26015}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+39 lines, -6 lines) Patch
M Makefile View 1 chunk +7 lines, -0 lines 0 comments Download
M build/toolchain.gypi View 8 chunks +32 lines, -6 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
jochen (gone - plz use gerrit)
5 years, 11 months ago (2015-01-09 14:47:01 UTC) #1
dcarney
lgtm
5 years, 11 months ago (2015-01-09 16:00:05 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/846653002/1
5 years, 11 months ago (2015-01-09 16:01:02 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 11 months ago (2015-01-09 16:25:44 UTC) #6
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/77e3e48ee23cccc990f82e1e744da2ad045002f1 Cr-Commit-Position: refs/heads/master@{#26015}
5 years, 11 months ago (2015-01-09 16:26:03 UTC) #7
Michael Achenbach
5 years, 11 months ago (2015-01-09 16:45:18 UTC) #8
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698