Verify that Api function's instance call handler is actually a CallHandlerInfo structure.

Verify that Api function's instance call handler is actually a CallHandlerInfo structure.

This is to ensure that chromium:443798 is caused by a random memory
corruption.

Committed: https://crrev.com/c95b3274e2e2d8c97ab0f8508fbc25290d7826ee
Cr-Commit-Position: refs/heads/master@{#26008}

[Igor Sheludko, 2015-01-09 11:36:35]

ishell@chromium.org changed reviewers:
+ jkummerow@chromium.org

[Igor Sheludko, 2015-01-09 11:36:35]

PTAL

[Jakob Kummerow, 2015-01-09 11:49:53]

LGTM with comment.

https://codereview.chromium.org/846613002/diff/1/src/builtins.cc
File src/builtins.cc (right):

https://codereview.chromium.org/846613002/diff/1/src/builtins.cc#newcode1092
src/builtins.cc:1092: DCHECK(function->shared()->IsApiFunction());
Let's temporarily turn this (and line 1188) into a CHECK as well.

[Igor Sheludko, 2015-01-09 11:52:05]

https://codereview.chromium.org/846613002/diff/1/src/builtins.cc
File src/builtins.cc (right):

https://codereview.chromium.org/846613002/diff/1/src/builtins.cc#newcode1092
src/builtins.cc:1092: DCHECK(function->shared()->IsApiFunction());
On 2015/01/09 11:49:53, Jakob wrote:
> Let's temporarily turn this (and line 1188) into a CHECK as well.

Done.

[Igor Sheludko, 2015-01-09 11:52:09]

The CQ bit was checked by ishell@chromium.org

[commit-bot: I haz the power, 2015-01-09 11:53:01]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/846613002/20001

[commit-bot: I haz the power, 2015-01-09 12:17:25]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-01-09 12:17:39]

Patchset 2 (id:??) landed as
https://crrev.com/c95b3274e2e2d8c97ab0f8508fbc25290d7826ee
Cr-Commit-Position: refs/heads/master@{#26008}