Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(601)

Side by Side Diff: runtime/vm/intermediate_language_arm.cc

Issue 846553003: Support unboxed input to indirect goto instruction. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « runtime/vm/intermediate_language.h ('k') | runtime/vm/intermediate_language_arm64.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 #include "vm/globals.h" // Needed here to get TARGET_ARCH_ARM. 5 #include "vm/globals.h" // Needed here to get TARGET_ARCH_ARM.
6 #if defined(TARGET_ARCH_ARM) 6 #if defined(TARGET_ARCH_ARM)
7 7
8 #include "vm/intermediate_language.h" 8 #include "vm/intermediate_language.h"
9 9
10 #include "vm/cpu.h" 10 #include "vm/cpu.h"
(...skipping 6760 matching lines...) Expand 10 before | Expand all | Expand 10 after
6771 6771
6772 6772
6773 void IndirectGotoInstr::EmitNativeCode(FlowGraphCompiler* compiler) { 6773 void IndirectGotoInstr::EmitNativeCode(FlowGraphCompiler* compiler) {
6774 Register target_address_reg = locs()->temp_slot(0)->reg(); 6774 Register target_address_reg = locs()->temp_slot(0)->reg();
6775 6775
6776 // Load from [current frame pointer] + kPcMarkerSlotFromFp. 6776 // Load from [current frame pointer] + kPcMarkerSlotFromFp.
6777 __ ldr(target_address_reg, Address(FP, kPcMarkerSlotFromFp * kWordSize)); 6777 __ ldr(target_address_reg, Address(FP, kPcMarkerSlotFromFp * kWordSize));
6778 6778
6779 // Add the offset. 6779 // Add the offset.
6780 Register offset_reg = locs()->in(0).reg(); 6780 Register offset_reg = locs()->in(0).reg();
6781 __ add(target_address_reg, 6781 Operand offset_opr =
6782 target_address_reg, 6782 offset()->definition()->representation() == kTagged ?
Vyacheslav Egorov (Google) 2015/01/09 15:49:21 consider ( ) around comparison.
zerny-google 2015/01/12 06:05:14 Done.
6783 Operand(offset_reg, ASR, kSmiTagSize)); 6783 Operand(offset_reg, ASR, kSmiTagSize) :
6784 Operand(offset_reg);
6785 __ add(target_address_reg, target_address_reg, offset_opr);
6784 6786
6785 // Jump to the absolute address. 6787 // Jump to the absolute address.
6786 __ bx(target_address_reg); 6788 __ bx(target_address_reg);
6787 } 6789 }
6788 6790
6789 6791
6790 LocationSummary* StrictCompareInstr::MakeLocationSummary(Isolate* isolate, 6792 LocationSummary* StrictCompareInstr::MakeLocationSummary(Isolate* isolate,
6791 bool opt) const { 6793 bool opt) const {
6792 const intptr_t kNumInputs = 2; 6794 const intptr_t kNumInputs = 2;
6793 const intptr_t kNumTemps = 0; 6795 const intptr_t kNumTemps = 0;
(...skipping 132 matching lines...) Expand 10 before | Expand all | Expand 10 after
6926 compiler->GenerateCall(token_pos(), &label, stub_kind_, locs()); 6928 compiler->GenerateCall(token_pos(), &label, stub_kind_, locs());
6927 #if defined(DEBUG) 6929 #if defined(DEBUG)
6928 __ LoadImmediate(R4, kInvalidObjectPointer); 6930 __ LoadImmediate(R4, kInvalidObjectPointer);
6929 __ LoadImmediate(R5, kInvalidObjectPointer); 6931 __ LoadImmediate(R5, kInvalidObjectPointer);
6930 #endif 6932 #endif
6931 } 6933 }
6932 6934
6933 } // namespace dart 6935 } // namespace dart
6934 6936
6935 #endif // defined TARGET_ARCH_ARM 6937 #endif // defined TARGET_ARCH_ARM
OLDNEW
« no previous file with comments | « runtime/vm/intermediate_language.h ('k') | runtime/vm/intermediate_language_arm64.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698