Issue 846543002: Make CancelableCallback::weak_factory_ the last member

Issue 846543002: Make CancelableCallback::weak_factory_ the last member (Closed)

Created:
5 years, 11 months ago by dmichael (off chromium)

Modified:
5 years, 11 months ago

Reviewers:
Nico

CC:
chromium-reviews, erikwright+watch_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

Make CancelableCallback::weak_factory_ the last member. BUG=303818, 433583 Committed: https://crrev.com/57c885a05f8d948f0a8c6b34b2ed7d6b3cd09b58 Cr-Commit-Position: refs/heads/master@{#311389}

Created: 5 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -7 lines)			Patch
	M	base/cancelable_callback.h	View	1 2 3	2 chunks	+4 lines, -7 lines	0 comments	Download

Total messages: 8 (3 generated)

dmichael (off chromium)

Note, the fix for crbug.com/433583 is in https://codereview.chromium.org/851553003/ which must land before this one. You ...

5 years, 11 months ago (2015-01-12 21:38:00 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/846543002/80001

5 years, 11 months ago (2015-01-14 00:35:06 UTC) #6

commit-bot: I haz the power

5 years, 11 months ago (2015-01-14 01:39:20 UTC) #8

Message was sent while issue was closed.

Patchset 4 (id:??) landed as
https://crrev.com/57c885a05f8d948f0a8c6b34b2ed7d6b3cd09b58
Cr-Commit-Position: refs/heads/master@{#311389}