Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(311)

Issue 846513002: Fix Mobile YouTube Plugin replacement content. (Closed)

Created:
5 years, 11 months ago by benm (inactive)
Modified:
5 years, 11 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix Mobile YouTube Plugin replacement content. When Chrome for Android encounters a Flash based YouTube embed, it renders a plugin replacement that redirects to the Android YoutTube app. The HTML that describes the plugin replacement got broken in the refactorings for crrev.com/297078 BUG=447290 TBR=arv@chromium.org Committed: https://crrev.com/356b1bd7f88c7c2fb5003406561668a4dc68d83c Cr-Commit-Position: refs/heads/master@{#310758}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M chrome/renderer/resources/mobile_youtube_plugin.html View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 11 (3 generated)
benm (inactive)
ptal!
5 years, 11 months ago (2015-01-08 18:57:02 UTC) #2
benm (inactive)
+Bernhard as owner of the mobile youtube plugin component, which is where this is actually ...
5 years, 11 months ago (2015-01-09 10:04:30 UTC) #4
Bernhard Bauer
lgtm
5 years, 11 months ago (2015-01-09 11:39:54 UTC) #5
benm (inactive)
TBR'ing arv@ for OWNERS as it's a trivial change and I'd like to make the ...
5 years, 11 months ago (2015-01-09 11:42:20 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/846513002/1
5 years, 11 months ago (2015-01-09 11:43:15 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 11 months ago (2015-01-09 11:46:59 UTC) #9
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/356b1bd7f88c7c2fb5003406561668a4dc68d83c Cr-Commit-Position: refs/heads/master@{#310758}
5 years, 11 months ago (2015-01-09 11:48:04 UTC) #10
arv (Not doing code reviews)
5 years, 11 months ago (2015-01-09 20:52:23 UTC) #11
Message was sent while issue was closed.
LGTM

Powered by Google App Engine
This is Rietveld 408576698