Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(60)

Issue 846483002: Percentage heights can be resolved against any parent if writing mode is orthogonal. (Closed)

Created:
5 years, 11 months ago by mstensho (USE GERRIT)
Modified:
5 years, 11 months ago
CC:
blink-reviews, blink-reviews-rendering, Dominik Röttsches, eae+blinkwatch, jchaffraix+rendering, leviw+renderwatch, pdr+renderingwatchlist_chromium.org, zoltan1
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Percentage heights can be resolved against any parent if writing mode is orthogonal. It doesn't matter then if the height of the containing block is auto, since we're going to resolve the percentage height against a *width* anyway. Check for containing block writing mode orthogonality earlier. It used to be omitted for render flow threads (we'd just skip unconditionally), and we want to be able to resolve against the column width. This makes fast/multicol/fixed-column-percent-logical-height-orthogonal-writing-mode.html pass in the new multicol implementation. BUG=386567 R=jchaffraix@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=188612

Patch Set 1 #

Patch Set 2 : rebase master #

Patch Set 3 : Un-skip the same test for virtual/slimmingpaint. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -3 lines) Patch
M LayoutTests/TestExpectations View 1 2 2 chunks +0 lines, -2 lines 0 comments Download
M Source/core/rendering/RenderBox.cpp View 2 chunks +7 lines, -1 line 0 comments Download

Messages

Total messages: 5 (1 generated)
mstensho (USE GERRIT)
5 years, 11 months ago (2015-01-08 15:55:25 UTC) #1
Julien - ping for review
lgtm
5 years, 11 months ago (2015-01-19 09:28:40 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/846483002/40001
5 years, 11 months ago (2015-01-19 09:29:32 UTC) #4
commit-bot: I haz the power
5 years, 11 months ago (2015-01-19 10:40:46 UTC) #5
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=188612

Powered by Google App Engine
This is Rietveld 408576698