Push API: Add temporary debug log to track down crash

Push API: Add temporary debug log to track down crash

Specifically, for https://goto.google.com/gcmdriver-already-instantiated

Sample output:
[FATAL:gcm_profile_service.cc(155)] An instance of GCMProfileService already exists! Old profile: 0x9e9d75c0 Default 0 0 1 13065207799278578, new profile: 0x9e9d75c0 Default 0 0 1 13065207799278578

BUG=437827
Committed: https://crrev.com/934554c3f369c9821b0af3ae8a09ed55f29eafc9
Cr-Commit-Position: refs/heads/master@{#310593}

Committed: https://crrev.com/f5b540bcb9d54878c5dad58008f0d8aab9d98ffa
Cr-Commit-Position: refs/heads/master@{#310760}

[Bernhard Bauer, 2015-01-08 16:38:24]

bauerb@chromium.org changed reviewers:
+ bauerb@chromium.org

[Bernhard Bauer, 2015-01-08 16:38:25]

lgtm

https://codereview.chromium.org/846473003/diff/1/chrome/browser/services/gcm/...
File chrome/browser/services/gcm/gcm_profile_service.cc (right):

https://codereview.chromium.org/846473003/diff/1/chrome/browser/services/gcm/...
chrome/browser/services/gcm/gcm_profile_service.cc:153: // understood:
https://goto.google.com/gcmdriver-already-instantiated
Just reference the bug here.

[johnme, 2015-01-08 16:49:01]

https://codereview.chromium.org/846473003/diff/1/chrome/browser/services/gcm/...
File chrome/browser/services/gcm/gcm_profile_service.cc (right):

https://codereview.chromium.org/846473003/diff/1/chrome/browser/services/gcm/...
chrome/browser/services/gcm/gcm_profile_service.cc:153: // understood:
https://goto.google.com/gcmdriver-already-instantiated
On 2015/01/08 16:38:25, Bernhard Bauer wrote:
> Just reference the bug here.

Done.

[johnme, 2015-01-08 16:49:42]

johnme@chromium.org changed reviewers:
+ jianli@chromium.org

[jianli, 2015-01-08 20:00:09]

lgtm

[johnme, 2015-01-08 20:00:33]

The CQ bit was unchecked by johnme@chromium.org

[johnme, 2015-01-08 20:00:33]

The CQ bit was checked by johnme@chromium.org

[commit-bot: I haz the power, 2015-01-08 20:01:35]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/846473003/20001

[commit-bot: I haz the power, 2015-01-08 20:59:18]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-01-08 21:01:03]

Patchset 2 (id:??) landed as
https://crrev.com/934554c3f369c9821b0af3ae8a09ed55f29eafc9
Cr-Commit-Position: refs/heads/master@{#310593}

[mattm, 2015-01-09 02:36:38]

A revert of this CL (patchset #2 id:20001) has been created in
https://codereview.chromium.org/839153005/ by mattm@chromium.org.

The reason for reverting is: Speculative revert for Android Tests unit_tests
failures. 170 tests consistently crashing/failing with nothing printed in the
log (ex:
https://build.chromium.org/p/chromium.linux/builders/Android%20Tests/builds/1...

[ RUN      ] BrowsingDataRemoverTest.RemoveMultipleTypes
[ CRASHED      ]
)
.

[johnme, 2015-01-09 11:23:17]

Oops, I now clear debug_instance in the destructor, which will prevent a use
after free.

[johnme, 2015-01-09 11:23:23]

The CQ bit was checked by johnme@chromium.org

[commit-bot: I haz the power, 2015-01-09 11:24:10]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/846473003/40001

[commit-bot: I haz the power, 2015-01-09 12:12:28]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2015-01-09 12:13:26]

Patchset 3 (id:??) landed as
https://crrev.com/f5b540bcb9d54878c5dad58008f0d8aab9d98ffa
Cr-Commit-Position: refs/heads/master@{#310760}