Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(277)

Issue 846453006: Switch DeviceCloudPolicyInvalidator to shared InvalidationService (Closed)

Created:
5 years, 11 months ago by bartfab (slow)
Modified:
5 years, 10 months ago
CC:
chromium-reviews, stevenjb+watch_chromium.org, davemoore+watch_chromium.org, oshima+watch_chromium.org, nkostylev+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@f_1_442800_extract_affiliated_invalidation_service_provider
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Switch DeviceCloudPolicyInvalidator to shared InvalidationService The DeviceCloudPolicyInvalidator used to ensure that a suitable InvalidationService is available on its own. This CL makes it a consumer of AffiliatedInvalidationServiceProvider, which manages an InvalidationService that can be shared by DeviceCloudPolicyInvalidator and other consumers. BUG=442800 TEST=Updated unit tests Committed: https://crrev.com/3c52f3b793bc89e44f39503114437ba62f9a795a Cr-Commit-Position: refs/heads/master@{#313562}

Patch Set 1 #

Patch Set 2 : Updated after changes to CL 828953004. #

Patch Set 3 : Rebased. #

Patch Set 4 : Rebased. #

Patch Set 5 : Fixed test. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+84 lines, -911 lines) Patch
M chrome/browser/chromeos/policy/browser_policy_connector_chromeos.cc View 1 2 3 2 chunks +2 lines, -10 lines 0 comments Download
M chrome/browser/chromeos/policy/device_cloud_policy_invalidator.h View 1 2 chunks +18 lines, -59 lines 0 comments Download
M chrome/browser/chromeos/policy/device_cloud_policy_invalidator.cc View 1 2 chunks +17 lines, -241 lines 0 comments Download
M chrome/browser/chromeos/policy/device_cloud_policy_invalidator_unittest.cc View 1 2 3 4 7 chunks +43 lines, -601 lines 0 comments Download
M chrome/browser/policy/cloud/cloud_policy_invalidator.h View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 18 (5 generated)
bartfab (slow)
Hi Mattias, Could you take a look please?
5 years, 11 months ago (2015-01-14 18:35:26 UTC) #2
Mattias Nissler (ping if slow)
This LGTM, provided we don't need to change it to rebase on top of any ...
5 years, 11 months ago (2015-01-16 13:31:13 UTC) #3
bartfab (slow)
I had to make a small adjustment after changes to the AffiliatedInvalidationServiceProvider CL.
5 years, 11 months ago (2015-01-20 14:08:45 UTC) #4
Mattias Nissler (ping if slow)
Can you upload a rebased version so I can take another look?
5 years, 10 months ago (2015-01-28 09:03:46 UTC) #5
bartfab (slow)
On 2015/01/28 09:03:46, Mattias Nissler wrote: > Can you upload a rebased version so I ...
5 years, 10 months ago (2015-01-28 09:34:49 UTC) #6
Mattias Nissler (ping if slow)
On 2015/01/28 09:34:49, bartfab wrote: > On 2015/01/28 09:03:46, Mattias Nissler wrote: > > Can ...
5 years, 10 months ago (2015-01-28 09:38:26 UTC) #7
Mattias Nissler (ping if slow)
LGTM
5 years, 10 months ago (2015-01-28 09:39:56 UTC) #8
bartfab (slow)
On 2015/01/28 09:39:56, Mattias Nissler wrote: > LGTM Sorry for the time warp :). And ...
5 years, 10 months ago (2015-01-28 09:41:20 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/846453006/60001
5 years, 10 months ago (2015-01-28 15:56:50 UTC) #12
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_rel_ng on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_rel_ng/builds/19151)
5 years, 10 months ago (2015-01-28 17:21:02 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/846453006/100001
5 years, 10 months ago (2015-01-28 17:25:37 UTC) #16
commit-bot: I haz the power
Committed patchset #5 (id:100001)
5 years, 10 months ago (2015-01-28 19:43:22 UTC) #17
commit-bot: I haz the power
5 years, 10 months ago (2015-01-28 19:44:23 UTC) #18
Message was sent while issue was closed.
Patchset 5 (id:??) landed as
https://crrev.com/3c52f3b793bc89e44f39503114437ba62f9a795a
Cr-Commit-Position: refs/heads/master@{#313562}

Powered by Google App Engine
This is Rietveld 408576698