Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(343)

Issue 846443006: Include Mojo SDK/EDK via fully-qualified paths in Chromium code. (Closed)

Created:
5 years, 11 months ago by blundell
Modified:
5 years, 11 months ago
CC:
chromium-reviews, mlamouri+watch-content_chromium.org, feature-media-reviews_chromium.org, creis+watch_chromium.org, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, nasko+codewatch_chromium.org, jam, extensions-reviews_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin-cc_chromium.org, timvolodine, mkwst+moarreviews-renderer_chromium.org, chromium-apps-reviews_chromium.org, darin (slow to review), ben+mojo_chromium.org, cc-bugs_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Include Mojo SDK/EDK via fully-qualified paths in Chromium code. As a followup to the move of the Mojo SDK and EDK to live under //third_party, this CL updates Chromium code to include SDK/EDK headers via fully-qualified paths instead of relying on include_dirs that are exported by the Mojo targets. This CL also includes mechanical updates to DEPS files to satisfy checkdeps. Committed: https://crrev.com/471b74f430d7885283a7257de6923fdc86a94368 Cr-Commit-Position: refs/heads/master@{#312858}

Patch Set 1 #

Patch Set 2 : Reorder headers in nacl templates #

Patch Set 3 : Change import path #

Patch Set 4 : Rebase #

Patch Set 5 : Rebase #

Patch Set 6 : Fix include to satisfy checkdeps #

Unified diffs Side-by-side diffs Delta from patch set Stats (+216 lines, -213 lines) Patch
M chrome/DEPS View 1 2 3 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/mojo_web_ui_controller.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/mojo_web_ui_controller.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/DEPS View 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/base/run_all_unittests.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/nacl/loader/DEPS View 1 chunk +1 line, -1 line 0 comments Download
M components/nacl/loader/nacl_listener.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M content/DEPS View 2 chunks +4 lines, -4 lines 0 comments Download
M content/app/mojo/mojo_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/app/mojo/mojo_init.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M content/browser/battery_status/battery_monitor_integration_browsertest.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M content/browser/mojo/mojo_application_host.h View 1 chunk +2 lines, -2 lines 0 comments Download
M content/browser/mojo/mojo_application_host.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/permissions/permission_service_context.h View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/renderer_host/render_process_host_impl.h View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/webui/web_ui_data_source_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/webui/web_ui_mojo_browsertest.cc View 1 chunk +4 lines, -4 lines 0 comments Download
M content/child/mojo/mojo_application.h View 1 chunk +1 line, -1 line 0 comments Download
M content/child/web_data_consumer_handle_impl.h View 1 chunk +1 line, -1 line 0 comments Download
M content/child/web_data_consumer_handle_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/child/web_data_consumer_handle_impl_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/child/web_url_loader_impl.cc View 2 chunks +1 line, -1 line 0 comments Download
M content/common/mojo/service_registry_impl.h View 1 chunk +3 lines, -3 lines 0 comments Download
M content/common/render_frame_setup.mojom View 1 2 1 chunk +1 line, -1 line 0 comments Download
M content/public/browser/render_view_host.h View 1 chunk +1 line, -1 line 0 comments Download
M content/public/common/service_registry.h View 1 chunk +3 lines, -3 lines 0 comments Download
M content/renderer/mojo/service_registry_js_wrapper.h View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/mojo/service_registry_js_wrapper.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/render_frame_impl.cc View 1 2 3 4 2 chunks +2 lines, -2 lines 0 comments Download
M content/renderer/web_ui_mojo.h View 1 chunk +1 line, -1 line 0 comments Download
M device/DEPS View 1 chunk +1 line, -1 line 0 comments Download
M device/battery/battery_monitor_impl.h View 1 chunk +1 line, -1 line 0 comments Download
M device/serial/data_receiver.h View 1 chunk +1 line, -1 line 0 comments Download
M device/serial/data_sender.h View 1 chunk +1 line, -1 line 0 comments Download
M device/serial/data_sink_receiver.h View 1 chunk +1 line, -1 line 0 comments Download
M device/serial/data_sink_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M device/serial/data_source_sender.h View 1 chunk +1 line, -1 line 0 comments Download
M device/serial/data_source_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M device/serial/serial_connection.h View 1 chunk +1 line, -1 line 0 comments Download
M device/serial/serial_connection_factory.h View 1 chunk +1 line, -1 line 0 comments Download
M device/serial/serial_connection_unittest.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M device/serial/serial_device_enumerator.h View 1 chunk +1 line, -1 line 0 comments Download
M device/serial/serial_service_impl.h View 1 chunk +1 line, -1 line 0 comments Download
M device/serial/serial_service_unittest.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M device/test/DEPS View 1 chunk +1 line, -1 line 0 comments Download
M device/test/run_all_unittests.cc View 1 chunk +1 line, -1 line 0 comments Download
M extensions/DEPS View 1 chunk +1 line, -1 line 0 comments Download
M extensions/browser/api/mime_handler_private/mime_handler_private.cc View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
M extensions/browser/mojo/keep_alive_impl.h View 1 chunk +1 line, -1 line 0 comments Download
M extensions/browser/mojo/service_registration_manager.h View 1 chunk +1 line, -1 line 0 comments Download
M extensions/browser/mojo/stash_backend.h View 1 chunk +1 line, -1 line 0 comments Download
M extensions/renderer/DEPS View 1 chunk +1 line, -1 line 0 comments Download
M extensions/renderer/api_test_base.h View 1 chunk +3 lines, -3 lines 0 comments Download
M extensions/renderer/api_test_base.cc View 1 chunk +5 lines, -5 lines 0 comments Download
M extensions/renderer/dispatcher.cc View 1 2 3 4 2 chunks +1 line, -1 line 0 comments Download
M extensions/renderer/mojo/keep_alive_client_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M extensions/test/DEPS View 1 chunk +1 line, -1 line 0 comments Download
M extensions/test/extensions_unittests_main.cc View 1 chunk +1 line, -1 line 0 comments Download
M ipc/mojo/DEPS View 1 chunk +2 lines, -2 lines 0 comments Download
M ipc/mojo/async_handle_waiter.h View 1 chunk +1 line, -1 line 0 comments Download
M ipc/mojo/async_handle_waiter.cc View 1 chunk +1 line, -1 line 0 comments Download
M ipc/mojo/async_handle_waiter_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M ipc/mojo/ipc_channel_mojo.h View 1 chunk +2 lines, -2 lines 0 comments Download
M ipc/mojo/ipc_channel_mojo.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M ipc/mojo/ipc_message_pipe_reader.h View 1 chunk +2 lines, -2 lines 0 comments Download
M ipc/mojo/ipc_mojo_bootstrap.h View 1 chunk +1 line, -1 line 0 comments Download
M ipc/mojo/ipc_mojo_bootstrap.cc View 1 chunk +1 line, -1 line 0 comments Download
M ipc/mojo/ipc_mojo_perftest.cc View 1 chunk +1 line, -1 line 0 comments Download
M ipc/mojo/run_all_unittests.cc View 1 chunk +1 line, -1 line 0 comments Download
M media/mojo/DEPS View 1 chunk +1 line, -1 line 0 comments Download
M media/mojo/services/mojo_cdm.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M media/mojo/services/mojo_cdm_promise.h View 1 chunk +1 line, -1 line 0 comments Download
M media/mojo/services/mojo_cdm_service.h View 1 chunk +1 line, -1 line 0 comments Download
M media/mojo/services/mojo_demuxer_stream_adapter.cc View 1 chunk +1 line, -1 line 0 comments Download
M media/mojo/services/mojo_demuxer_stream_impl.h View 1 chunk +1 line, -1 line 0 comments Download
M media/mojo/services/mojo_demuxer_stream_impl.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M media/mojo/services/mojo_media_application.cc View 1 chunk +5 lines, -5 lines 0 comments Download
M media/mojo/services/mojo_renderer_factory.h View 1 chunk +1 line, -1 line 0 comments Download
M media/mojo/services/mojo_renderer_impl.cc View 1 2 3 1 chunk +3 lines, -3 lines 0 comments Download
M media/mojo/services/mojo_renderer_service.h View 1 chunk +1 line, -1 line 0 comments Download
M media/mojo/services/mojo_type_trait.h View 1 chunk +2 lines, -2 lines 0 comments Download
M media/test/DEPS View 1 chunk +1 line, -1 line 0 comments Download
M media/test/pipeline_integration_test.cc View 1 2 3 4 1 chunk +3 lines, -3 lines 0 comments Download
M mojo/DEPS View 1 chunk +3 lines, -1 line 0 comments Download
M mojo/android/javatests/init_library.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M mojo/android/javatests/mojo_test_case.cc View 1 chunk +1 line, -1 line 0 comments Download
M mojo/android/javatests/validation_test_util.cc View 1 chunk +1 line, -1 line 0 comments Download
M mojo/android/system/core_impl.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M mojo/application/application_runner_chromium.h View 1 chunk +1 line, -1 line 0 comments Download
M mojo/application/application_runner_chromium.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M mojo/application/application_test_main_chromium.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M mojo/cc/context_provider_mojo.h View 1 chunk +2 lines, -2 lines 0 comments Download
M mojo/cc/context_provider_mojo.cc View 1 chunk +1 line, -1 line 0 comments Download
M mojo/common/DEPS View 1 chunk +1 line, -1 line 0 comments Download
M mojo/common/common_type_converters.h View 1 chunk +3 lines, -3 lines 0 comments Download
M mojo/common/data_pipe_utils.h View 1 chunk +1 line, -1 line 0 comments Download
M mojo/common/handle_watcher.h View 1 chunk +1 line, -1 line 0 comments Download
M mojo/common/handle_watcher_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M mojo/common/message_pump_mojo.h View 1 chunk +1 line, -1 line 0 comments Download
M mojo/common/message_pump_mojo_handler.h View 1 chunk +1 line, -1 line 0 comments Download
M mojo/common/message_pump_mojo_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M mojo/environment/default_async_waiter_impl.h View 1 chunk +1 line, -1 line 0 comments Download
M mojo/environment/default_logger_impl.h View 1 chunk +1 line, -1 line 0 comments Download
M mojo/environment/environment.cc View 1 chunk +1 line, -1 line 0 comments Download
M mojo/nacl/generator/libmojo.cc.tmpl View 1 1 chunk +1 line, -1 line 0 comments Download
M mojo/nacl/generator/mojo_syscall.cc.tmpl View 1 1 chunk +1 line, -1 line 0 comments Download
M mojo/nacl/monacl_shell.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M mojo/services/DEPS View 1 chunk +1 line, -0 lines 0 comments Download
M mojo/services/html_viewer/ax_provider_impl.h View 1 chunk +1 line, -1 line 0 comments Download
M mojo/services/html_viewer/blink_basic_type_converters.h View 1 chunk +2 lines, -2 lines 0 comments Download
M mojo/services/html_viewer/blink_basic_type_converters.cc View 1 chunk +1 line, -1 line 0 comments Download
M mojo/services/html_viewer/blink_url_request_type_converters.cc View 1 chunk +1 line, -1 line 0 comments Download
M mojo/services/html_viewer/html_document.h View 1 2 3 4 2 chunks +5 lines, -5 lines 0 comments Download
M mojo/services/html_viewer/html_document.cc View 1 2 3 4 2 chunks +3 lines, -3 lines 0 comments Download
M mojo/services/html_viewer/html_viewer.cc View 1 2 3 2 chunks +6 lines, -6 lines 0 comments Download
M mojo/services/html_viewer/mojo_blink_platform_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M mojo/services/html_viewer/webmediaplayer_factory.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M mojo/services/network/net_address_type_converters.h View 1 chunk +1 line, -1 line 0 comments Download
M mojo/services/network/network_service.cc View 1 2 3 1 chunk +5 lines, -5 lines 0 comments Download
M mojo/services/network/network_service_impl.h View 1 chunk +1 line, -1 line 0 comments Download
M mojo/services/network/network_service_impl.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M mojo/services/network/public/DEPS View 1 chunk +1 line, -1 line 0 comments Download
M mojo/services/network/public/cpp/udp_socket_wrapper.cc View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M mojo/services/network/public/cpp/web_socket_read_queue.h View 1 chunk +1 line, -1 line 0 comments Download
M mojo/services/network/public/cpp/web_socket_write_queue.h View 1 chunk +1 line, -1 line 0 comments Download
M mojo/services/network/tcp_bound_socket_impl.h View 1 chunk +1 line, -1 line 0 comments Download
M mojo/services/network/tcp_connected_socket_impl.h View 1 chunk +1 line, -1 line 0 comments Download
M mojo/services/network/tcp_server_socket_impl.h View 1 chunk +1 line, -1 line 0 comments Download
M mojo/services/network/udp_socket_impl.h View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M mojo/services/network/udp_socket_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M mojo/services/network/url_loader_impl.h View 1 2 3 1 chunk +3 lines, -3 lines 0 comments Download
M mojo/services/network/web_socket_impl.h View 1 chunk +1 line, -1 line 0 comments Download
M ppapi/tests/mojo/DEPS View 1 chunk +1 line, -1 line 0 comments Download
M ppapi/tests/mojo/test_mojo.cc View 1 chunk +1 line, -1 line 0 comments Download
M third_party/khronos/DEPS View 1 chunk +1 line, -1 line 0 comments Download
M third_party/khronos/KHR/khrplatform.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/keyboard/webui/DEPS View 1 chunk +1 line, -1 line 0 comments Download
M ui/keyboard/webui/vk_mojo_handler.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/keyboard/webui/vk_webui_controller.h View 1 chunk +2 lines, -2 lines 0 comments Download
M ui/keyboard/webui/vk_webui_controller.cc View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 37 (17 generated)
blundell
Hi Ben, Could you look over this before I send it to beng for owners?
5 years, 11 months ago (2015-01-20 11:34:42 UTC) #2
blundell
Hi Ben G, Could you review this and/or rubberstamp it as you see fit? Thanks!
5 years, 11 months ago (2015-01-20 16:45:37 UTC) #4
Ben Goodger (Google)
lgtm
5 years, 11 months ago (2015-01-20 20:53:20 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/846443006/40001
5 years, 11 months ago (2015-01-21 19:52:50 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: android_dbg_tests_recipe on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/android_dbg_tests_recipe/builds/46714)
5 years, 11 months ago (2015-01-21 20:01:27 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/846443006/60001
5 years, 11 months ago (2015-01-21 22:04:27 UTC) #12
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/37398) Try jobs failed on following ...
5 years, 11 months ago (2015-01-21 22:14:47 UTC) #14
blundell
Hi Tom, Could you review https://codereview.chromium.org/846443006/diff/60001/content/common/render_frame_setup.mojom? Thanks!
5 years, 11 months ago (2015-01-22 08:52:51 UTC) #16
Tom Sepez
RS LGTM on changing paths.
5 years, 11 months ago (2015-01-22 17:37:26 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/846443006/60001
5 years, 11 months ago (2015-01-22 17:38:59 UTC) #19
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/37398)
5 years, 11 months ago (2015-01-22 17:39:58 UTC) #21
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/846443006/60001
5 years, 11 months ago (2015-01-22 17:44:59 UTC) #23
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_rel_ng on tryserver.chromium.mac (http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/25896)
5 years, 11 months ago (2015-01-22 17:49:44 UTC) #25
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/846443006/80001
5 years, 11 months ago (2015-01-23 10:50:36 UTC) #27
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/25187)
5 years, 11 months ago (2015-01-23 12:21:44 UTC) #29
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/846443006/80001
5 years, 11 months ago (2015-01-23 12:23:50 UTC) #31
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/25187)
5 years, 11 months ago (2015-01-23 13:56:03 UTC) #33
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/846443006/100001
5 years, 11 months ago (2015-01-23 14:34:33 UTC) #35
commit-bot: I haz the power
Committed patchset #6 (id:100001)
5 years, 11 months ago (2015-01-23 16:27:47 UTC) #36
commit-bot: I haz the power
5 years, 11 months ago (2015-01-23 16:28:25 UTC) #37
Message was sent while issue was closed.
Patchset 6 (id:??) landed as
https://crrev.com/471b74f430d7885283a7257de6923fdc86a94368
Cr-Commit-Position: refs/heads/master@{#312858}

Powered by Google App Engine
This is Rietveld 408576698