ServiceWorker: ReadRegistration should return NOT_FOUND when the database is not initialized

ServiceWorker: ReadRegistration should return NOT_FOUND when the database is not initialized

ServiceWorkerDatabase::ReadRegistration and ReadUserData should return NOT_FOUND
when the database hasn't been initialized yet, but the current implementation
wrongly returns STATUS_OK without any valid data. This CL fixes it.

BUG=447469
TEST=content_unittests --gtest_filter=ServiceWorkerDatabaseTest.*

Committed: https://crrev.com/37d762951ba5ce0bb3277e0a1457546aacdaf4c0
Cr-Commit-Position: refs/heads/master@{#310749}

[nhiroki, 2015-01-09 07:17:24]

Patchset #1 (id:1) has been deleted

[nhiroki, 2015-01-09 07:17:30]

Patchset #1 (id:20001) has been deleted

[nhiroki, 2015-01-09 07:19:47]

nhiroki@chromium.org changed reviewers:
+ falken@chromium.org

[nhiroki, 2015-01-09 07:19:58]

Ptal, thanks!

[falken, 2015-01-09 07:54:35]

lgtm

https://codereview.chromium.org/846443005/diff/30001/content/browser/service_...
File content/browser/service_worker/service_worker_database_unittest.cc (right):

https://codereview.chromium.org/846443005/diff/30001/content/browser/service_...
content/browser/service_worker/service_worker_database_unittest.cc:1039:
database->WriteUserData(100, kOrigin, "key", "data"));
nit: Maybe comment here that it should succeed or else add whitespace so it
doesn't look like line 1034 pertains to it.

[nhiroki, 2015-01-09 08:23:29]

Thank you!

https://codereview.chromium.org/846443005/diff/30001/content/browser/service_...
File content/browser/service_worker/service_worker_database_unittest.cc (right):

https://codereview.chromium.org/846443005/diff/30001/content/browser/service_...
content/browser/service_worker/service_worker_database_unittest.cc:1039:
database->WriteUserData(100, kOrigin, "key", "data"));
On 2015/01/09 07:54:35, falken wrote:
> nit: Maybe comment here that it should succeed or else add whitespace so it
> doesn't look like line 1034 pertains to it.

Done.

[nhiroki, 2015-01-09 08:23:38]

The CQ bit was checked by nhiroki@chromium.org

[commit-bot: I haz the power, 2015-01-09 08:24:19]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/846443005/50001

[commit-bot: I haz the power, 2015-01-09 10:33:45]

Committed patchset #2 (id:50001)

[commit-bot: I haz the power, 2015-01-09 10:34:40]

Patchset 2 (id:??) landed as
https://crrev.com/37d762951ba5ce0bb3277e0a1457546aacdaf4c0
Cr-Commit-Position: refs/heads/master@{#310749}