Update the metrics side bar pane and computed style pane after main frame resize.

Update the metrics side bar pane and computed style pane after main frame resize.

The metrics pane showing width and height of the main frame should be updated upon receiving
the resize event. This also applies while docking/undocking the DevTools window.

BUG=322997
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=163004

[vivekg, 2013-11-24 10:26:17]

Please review the changes and let me know your feedback. Thanks!

[vivekg, 2013-11-24 10:30:04]

Should we also add inspector layout test for this one, as well as a protocol
test?

[pfeldman, 2013-11-26 16:26:01]

https://codereview.chromium.org/84643002/diff/1/Source/devtools/front_end/Met...
File Source/devtools/front_end/MetricsSidebarPane.js (right):

https://codereview.chromium.org/84643002/diff/1/Source/devtools/front_end/Met...
Source/devtools/front_end/MetricsSidebarPane.js:94: this._innerUpdate();
We probably want to throttle this.

[vivekg, 2013-11-26 16:32:55]

On 2013/11/26 16:26:01, pfeldman wrote:
>
https://codereview.chromium.org/84643002/diff/1/Source/devtools/front_end/Met...
> File Source/devtools/front_end/MetricsSidebarPane.js (right):
> 
>
https://codereview.chromium.org/84643002/diff/1/Source/devtools/front_end/Met...
> Source/devtools/front_end/MetricsSidebarPane.js:94: this._innerUpdate();
> We probably want to throttle this.

Any ideas about how to throttle it? Are you suggesting of partial updates of
just the height and the width and relevant properties?

[pfeldman, 2013-11-26 16:36:07]

> Any ideas about how to throttle it? Are you suggesting of partial updates of
> just the height and the width and relevant properties?

I was more thinking about setTimeout-kind of throttling.

[vivekg, 2013-11-26 16:40:13]

> 
> I was more thinking about setTimeout-kind of throttling.

Oh I see! Sounds good to me. Just want to understand that the metrics pane would
be updated asynchronously due to usage of setTimeout() without blocking the main
event.

[vivekg, 2013-11-27 04:07:28]

Updated the patch, please take a look. Thanks!

[pfeldman, 2013-11-28 15:25:35]

https://codereview.chromium.org/84643002/diff/60001/Source/devtools/front_end...
File Source/devtools/front_end/MetricsSidebarPane.js (right):

https://codereview.chromium.org/84643002/diff/60001/Source/devtools/front_end...
Source/devtools/front_end/MetricsSidebarPane.js:98:
setTimeout(refreshContents.bind(this), 0);
This will not throttle anything - it will call innerUpdate as many times as
frameResized is called. You want to setTimeout for 100ms and reschedule it if
frameResized comes while the timer is in flight.

[vivekg, 2013-11-28 19:34:29]

On 2013/11/28 15:25:35, pfeldman wrote:
>
https://codereview.chromium.org/84643002/diff/60001/Source/devtools/front_end...
> File Source/devtools/front_end/MetricsSidebarPane.js (right):
> 
>
https://codereview.chromium.org/84643002/diff/60001/Source/devtools/front_end...
> Source/devtools/front_end/MetricsSidebarPane.js:98:
> setTimeout(refreshContents.bind(this), 0);
> This will not throttle anything - it will call innerUpdate as many times as
> frameResized is called. You want to setTimeout for 100ms and reschedule it if
> frameResized comes while the timer is in flight.

Yeah got it, sorry missed it earlier. Have uploaded a new patch, please take a
look, thanks!

[vivekg, 2013-12-02 06:53:13]

Friendly ping. :)

[pfeldman, 2013-12-02 12:28:25]

https://codereview.chromium.org/84643002/diff/80001/Source/devtools/front_end...
File Source/devtools/front_end/StylesSidebarPane.js (right):

https://codereview.chromium.org/84643002/diff/80001/Source/devtools/front_end...
Source/devtools/front_end/StylesSidebarPane.js:413: this._activeTimer =
setTimeout(refreshContents.bind(this), 100);
I'd rather throttle it once in the resource tree model.

[pfeldman, 2013-12-02 12:28:58]

On 2013/12/02 12:28:25, pfeldman wrote:
>
https://codereview.chromium.org/84643002/diff/80001/Source/devtools/front_end...
> File Source/devtools/front_end/StylesSidebarPane.js (right):
> 
>
https://codereview.chromium.org/84643002/diff/80001/Source/devtools/front_end...
> Source/devtools/front_end/StylesSidebarPane.js:413: this._activeTimer =
> setTimeout(refreshContents.bind(this), 100);
> I'd rather throttle it once in the resource tree model.

On a second thought - lgtm.

[vivekg, 2013-12-02 14:01:54]

On 2013/12/02 12:28:25, pfeldman wrote:
>
https://codereview.chromium.org/84643002/diff/80001/Source/devtools/front_end...
> File Source/devtools/front_end/StylesSidebarPane.js (right):
> 
>
https://codereview.chromium.org/84643002/diff/80001/Source/devtools/front_end...
> Source/devtools/front_end/StylesSidebarPane.js:413: this._activeTimer =
> setTimeout(refreshContents.bind(this), 100);
> I'd rather throttle it once in the resource tree model.

Thanks Pavel for the review. The reason I put the throttling logic at individual
place is to make individual sidebar pane aware about the purpose of this
throttling. Also, in case(s), the event frameResized needs to be listened
continuously, throttling it at resource model would not be convenient.

[vivekg, 2013-12-02 14:25:26]

On 2013/12/02 12:28:58, pfeldman wrote:
> On 2013/12/02 12:28:25, pfeldman wrote: 
> On a second thought - lgtm.

Great. Shall I go ahead and set the commit bit on this CL? :)

[pfeldman, 2013-12-02 15:47:16]

go ahead

[commit-bot: I haz the power, 2013-12-02 16:36:17]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/vivek.vg@samsung.com/84643002/80001

[commit-bot: I haz the power, 2013-12-02 17:40:04]

Change committed as 163004