Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(35)

Issue 846363002: Update gyp files to guarantee proper recreation when changing deps (Closed)

Created:
5 years, 11 months ago by jochen (gone - plz use gerrit)
Modified:
5 years, 11 months ago
Reviewers:
Michael Achenbach
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Update gyp files to guarantee proper recreation when changing deps Also make sure that x86_64 is mapped to x64 as target arch R=machenbach@chromium.org LOG=n BUG=none Committed: https://crrev.com/5d22f59d7befa81b8b71bcfe510396cc7cb77f71 Cr-Commit-Position: refs/heads/master@{#26052}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -3 lines) Patch
M Makefile View 3 chunks +11 lines, -3 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
jochen (gone - plz use gerrit)
5 years, 11 months ago (2015-01-14 09:33:02 UTC) #1
Michael Achenbach
lgtm
5 years, 11 months ago (2015-01-14 12:20:30 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/846363002/1
5 years, 11 months ago (2015-01-14 12:22:31 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 11 months ago (2015-01-14 12:48:34 UTC) #5
commit-bot: I haz the power
5 years, 11 months ago (2015-01-14 12:48:41 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/5d22f59d7befa81b8b71bcfe510396cc7cb77f71
Cr-Commit-Position: refs/heads/master@{#26052}

Powered by Google App Engine
This is Rietveld 408576698