Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(20)

Unified Diff: pkg/analyzer2dart/lib/src/cps_generator.dart

Issue 846353002: Dart2dart: Support for-loop variables captured in loop body. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/analyzer2dart/lib/src/cps_generator.dart
diff --git a/pkg/analyzer2dart/lib/src/cps_generator.dart b/pkg/analyzer2dart/lib/src/cps_generator.dart
index 369b5da89604245935560a5fa38d8bd2465690a2..d9eba2504571fbd526e551d3b7a1b8e0c3a2db00 100644
--- a/pkg/analyzer2dart/lib/src/cps_generator.dart
+++ b/pkg/analyzer2dart/lib/src/cps_generator.dart
@@ -443,16 +443,21 @@ class CpsGeneratingVisitor extends SemanticVisitor<ir.Node>
@override
visitForStatement(ForStatement node) {
// TODO(johnniwinther): Support `for` as a jump target.
+ List<dart2js.LocalElement> loopVariables = <dart2js.LocalElement>[];
SubbuildFunction buildInitializer;
if (node.variables != null) {
buildInitializer = subbuild(node.variables);
+ for (VariableDeclaration variable in node.variables.variables) {
+ loopVariables.add(converter.convertElement(variable.element));
+ }
} else {
buildInitializer = subbuild(node.initialization);
}
irBuilder.buildFor(buildInitializer: buildInitializer,
buildCondition: subbuild(node.condition),
buildBody: subbuild(node.body),
- buildUpdate: subbuildSequence(node.updaters));
+ buildUpdate: subbuildSequence(node.updaters),
+ loopVariables: loopVariables);
}
@override
« no previous file with comments | « no previous file | pkg/compiler/lib/src/cps_ir/cps_ir_builder.dart » ('j') | pkg/compiler/lib/src/cps_ir/cps_ir_builder.dart » ('J')

Powered by Google App Engine
This is Rietveld 408576698