Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(36)

Issue 8463013: Fix implicit conversions from bool to ParsingFlags.

Created:
9 years, 1 month ago by Steven
Modified:
9 years, 1 month ago
Reviewers:
Lasse Reichstein
CC:
v8-dev
Visibility:
Public.

Description

Fix implicit conversions from bool to ParsingFlags.

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -5 lines) Patch
M src/api.cc View 2 chunks +6 lines, -3 lines 0 comments Download
M test/cctest/test-parsing.cc View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
Steven
9 years, 1 month ago (2011-11-11 13:33:04 UTC) #1
PTAL. What do you think about also changing the type of the parameter to
ParsingFlags, at the expense of having to cast OR'ed values?

Powered by Google App Engine
This is Rietveld 408576698