Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4)

Issue 846183002: Remove tracking of pending sheets. (Closed)

Created:
5 years, 11 months ago by esprehn
Modified:
5 years, 11 months ago
Reviewers:
ojan
CC:
abarth-chromium, mojo-reviews_chromium.org, ojan
Base URL:
git@github.com:domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Remove tracking of pending sheets. I was going to remove all this anyway since we don't need it in sky, all sheets are local and there's no concept of a pending sheet now. I also removed the dirty bit I added to StyleSheetCollection. The bit is not correct and is preventing us from correctly processing sheets and invalidating style. I'll add it back later when I understand how to add the dirty bit correctly. R=ojan@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/e4ab7d74cc99092af0696ff11166889f5032b5ea

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+44 lines, -131 lines) Patch
M sky/engine/core/css/resolver/StyleResolver.h View 4 chunks +2 lines, -14 lines 0 comments Download
M sky/engine/core/css/resolver/StyleResolver.cpp View 4 chunks +0 lines, -39 lines 0 comments Download
M sky/engine/core/dom/Document.h View 1 chunk +0 lines, -1 line 0 comments Download
M sky/engine/core/dom/Document.cpp View 2 chunks +3 lines, -11 lines 0 comments Download
M sky/engine/core/dom/StyleEngine.h View 2 chunks +1 line, -20 lines 0 comments Download
M sky/engine/core/dom/StyleEngine.cpp View 4 chunks +8 lines, -35 lines 0 comments Download
M sky/engine/core/dom/StyleSheetCollection.h View 1 chunk +0 lines, -2 lines 0 comments Download
M sky/engine/core/dom/StyleSheetCollection.cpp View 4 chunks +3 lines, -9 lines 0 comments Download
A sky/tests/lowlevel/home.sky View 1 chunk +14 lines, -0 lines 0 comments Download
A sky/tests/lowlevel/home-expected.txt View 1 chunk +13 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
esprehn
5 years, 11 months ago (2015-01-13 02:10:36 UTC) #2
ojan
lgtm
5 years, 11 months ago (2015-01-13 02:14:13 UTC) #3
esprehn
5 years, 11 months ago (2015-01-13 02:15:27 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
e4ab7d74cc99092af0696ff11166889f5032b5ea (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698