Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(456)

Issue 846153005: Move WeakPtrFactory member to the end of LocalExtensionCache (Closed)

Created:
5 years, 11 months ago by dmichael (off chromium)
Modified:
5 years, 11 months ago
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Move WeakPtrFactory member to the end of LocalExtensionCache This forces WeakPtrs to be invalidated before other members' destructors run. See the bug or the documentation of WeakPtrFactory for more information. I'm in the process of trying to turn on a clang check for this (see the bug). BUG=303818 R=asargent@chromium.org Committed: https://crrev.com/167430259992ef059628ed69dae4e413d696cdcd Cr-Commit-Position: refs/heads/master@{#311376}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -5 lines) Patch
M chrome/browser/extensions/updater/local_extension_cache.h View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/browser/extensions/updater/local_extension_cache.cc View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
dmichael (off chromium)
5 years, 11 months ago (2015-01-13 23:40:08 UTC) #1
asargent_no_longer_on_chrome
lgtm A clang check for this would be great!
5 years, 11 months ago (2015-01-14 00:41:24 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/846153005/1
5 years, 11 months ago (2015-01-14 00:43:11 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 11 months ago (2015-01-14 00:48:08 UTC) #5
commit-bot: I haz the power
5 years, 11 months ago (2015-01-14 00:49:52 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/167430259992ef059628ed69dae4e413d696cdcd
Cr-Commit-Position: refs/heads/master@{#311376}

Powered by Google App Engine
This is Rietveld 408576698