Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(586)

Issue 846113004: [DevTools] Add stub handlers for synthetic gesture commands. (Closed)

Created:
5 years, 11 months ago by samuong
Modified:
5 years, 10 months ago
CC:
chromium-reviews, jam, yurys, paulirish+reviews_chromium.org, darin-cc_chromium.org, devtools-reviews_chromium.org, aandrey+blink_chromium.org, pfeldman
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[DevTools] Add stub handlers for synthetic gesture commands. This is the first of three CLs to add synthetic gesture commands to the DevTools Input domain. The changes need to be split up so that the code generated from protocol.json has some stub functions to call. 1. crrev.com/846113004 2. crrev.com/841013002 3. crrev.com/792883007 BUG=448182 Committed: https://crrev.com/1b5ccef52b9410ab6efeecdc9a2dc156acdbbbfe Cr-Commit-Position: refs/heads/master@{#317371}

Patch Set 1 #

Patch Set 2 : change gesture_source_type to a string #

Patch Set 3 : merge Scroll, Swipe, ScrollBounce commands #

Patch Set 4 : change scroll command and rebase #

Patch Set 5 : add gesture source type to pinch gesture params #

Patch Set 6 : change xs/ys parameters to {x/y}{distance/overscroll} #

Total comments: 4

Patch Set 7 : fix nits #

Patch Set 8 : fix windows build error #

Patch Set 9 : |const scoped_ptr<Client>&| -> |scoped_ptr<DevToolsProtocolClient>| #

Unified diffs Side-by-side diffs Delta from patch set Stats (+64 lines, -1 line) Patch
M content/browser/devtools/protocol/input_handler.h View 1 2 3 4 5 6 7 8 2 chunks +27 lines, -1 line 0 comments Download
M content/browser/devtools/protocol/input_handler.cc View 1 2 3 4 5 6 7 8 2 chunks +37 lines, -0 lines 0 comments Download

Messages

Total messages: 16 (7 generated)
samuong
5 years, 11 months ago (2015-01-14 05:11:31 UTC) #2
samuong
This is the first of three CLs to add synthetic gesture commands to the DevTools ...
5 years, 11 months ago (2015-01-14 05:13:51 UTC) #4
samuong
5 years, 10 months ago (2015-02-13 22:52:52 UTC) #6
dgozman
lgtm https://codereview.chromium.org/846113004/diff/120001/content/browser/devtools/protocol/input_handler.h File content/browser/devtools/protocol/input_handler.h (right): https://codereview.chromium.org/846113004/diff/120001/content/browser/devtools/protocol/input_handler.h#newcode49 content/browser/devtools/protocol/input_handler.h:49: const int* xdistance, x_distance https://codereview.chromium.org/846113004/diff/120001/content/browser/devtools/protocol/input_handler.h#newcode50 content/browser/devtools/protocol/input_handler.h:50: const int* ...
5 years, 10 months ago (2015-02-19 10:04:58 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/846113004/140001
5 years, 10 months ago (2015-02-19 18:13:03 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: win8_chromium_rel on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win8_chromium_rel/builds/56187)
5 years, 10 months ago (2015-02-19 19:09:29 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/846113004/180001
5 years, 10 months ago (2015-02-20 18:19:05 UTC) #14
commit-bot: I haz the power
Committed patchset #9 (id:180001)
5 years, 10 months ago (2015-02-20 19:30:33 UTC) #15
commit-bot: I haz the power
5 years, 10 months ago (2015-02-20 19:31:32 UTC) #16
Message was sent while issue was closed.
Patchset 9 (id:??) landed as
https://crrev.com/1b5ccef52b9410ab6efeecdc9a2dc156acdbbbfe
Cr-Commit-Position: refs/heads/master@{#317371}

Powered by Google App Engine
This is Rietveld 408576698