Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(101)

Issue 846073005: GN: Fix for chromeos building. (Closed)

Created:
5 years, 11 months ago by tfarina
Modified:
5 years, 11 months ago
Reviewers:
Dirk Pranke, brettw, eae
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

GN: Fix for chromeos building. Tested with the following command lines: $ gn gen --args='os="chromeos"' out_gn_chromeos/Debug and $ gn gen --args='os="android" cpu_arch="arm"' out_gn_android/Debug See gn-dev mailing-list thread discussion: https://groups.google.com/a/chromium.org/d/topic/gn-dev/Mq2ycNv4vRg/discussion BUG=None TEST=see above R=brettw@chromium.org,eae@chromium.org Committed: https://crrev.com/cd8452bc113fe8c6a1566b0c6ed5245a7a230e43 Cr-Commit-Position: refs/heads/master@{#311193}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -15 lines) Patch
M third_party/harfbuzz-ng/BUILD.gn View 2 chunks +12 lines, -15 lines 0 comments Download

Messages

Total messages: 16 (5 generated)
tfarina
5 years, 11 months ago (2015-01-13 01:51:57 UTC) #1
eae
LGTM
5 years, 11 months ago (2015-01-13 02:10:08 UTC) #3
Dirk Pranke
lgtm. make sure you run it through the chromeos gn bots, though, since they're not ...
5 years, 11 months ago (2015-01-13 02:17:44 UTC) #5
brettw
On 2015/01/13 02:17:44, Dirk Pranke wrote: > lgtm. make sure you run it through the ...
5 years, 11 months ago (2015-01-13 02:20:56 UTC) #6
brettw
lgtm
5 years, 11 months ago (2015-01-13 02:23:19 UTC) #7
Dirk Pranke
On 2015/01/13 02:20:56, brettw wrote: > On 2015/01/13 02:17:44, Dirk Pranke wrote: > > lgtm. ...
5 years, 11 months ago (2015-01-13 02:28:03 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/846073005/1
5 years, 11 months ago (2015-01-13 02:46:16 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: ios_dbg_simulator on tryserver.chromium.mac (http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator/builds/48306)
5 years, 11 months ago (2015-01-13 02:52:15 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/846073005/1
5 years, 11 months ago (2015-01-13 02:58:41 UTC) #14
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 11 months ago (2015-01-13 03:08:41 UTC) #15
commit-bot: I haz the power
5 years, 11 months ago (2015-01-13 03:10:14 UTC) #16
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/cd8452bc113fe8c6a1566b0c6ed5245a7a230e43
Cr-Commit-Position: refs/heads/master@{#311193}

Powered by Google App Engine
This is Rietveld 408576698