In SkPDFDocument::emitPDF(), stop pre-calculating file offsets.

In SkPDFDocument::emitPDF(), stop pre-calculating file offsets.

* Add Streamer utility class which measures the current
  pdf offset by calling SkWStream::bytesWritten(). Calls
  SkPDFCatalog::setFileOffset() and SkPDFObject::emit() at
  the same time to guarantee that everything works out.

* SkPDFCatalog::setFileOffset() no longer calculates the
  object's size.

* SkPDFCatalog::setSubstituteResourcesOffsets() removed.

* SkPDFCatalog::emitSubstituteResources() removed and
  getSubstituteList() made public in its place.

* Remove SkPDFPage::getPageSize and SkPDFPage::emitPage.
  Replace with SkPDFPage::getContentStream().

* SkPDFObject::getOutputSize no longer virtual, only used in
  unit tests.  All SkPDFObject subclasses getOutputSize()
  overrides removed.

* SkPDFObject::getIndirectOutputSize removed.

* PDFPrimitivesTest updated for new functions.

Committed: https://skia.googlesource.com/skia/+/f361b714390422a5c2a8b1dacb8e67502d0e40bb

[hal.canary, 2015-01-12 19:46:35]

The CQ bit was checked by halcanary@google.com

[commit-bot: I haz the power, 2015-01-12 19:47:13]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/846023003/1

[commit-bot: I haz the power, 2015-01-12 19:47:14]

Note for Reviewers:
The CQ is waiting for an approval.
If you believe that the CL is not ready yet, or if you would like to L-G-T-M
with comments then please uncheck the CQ checkbox.

Waiting for LGTM from valid reviewer(s) till 2015-01-13 01:47 UTC

[hal.canary, 2015-01-12 19:47:34]

The CQ bit was unchecked by halcanary@google.com

[hal.canary, 2015-01-12 19:47:50]

halcanary@google.com changed reviewers:
+ djsollen@google.com

[hal.canary, 2015-01-12 19:47:51]

ptal

[djsollen, 2015-01-13 13:49:47]

https://codereview.chromium.org/846023003/diff/1/src/pdf/SkPDFDocument.cpp
File src/pdf/SkPDFDocument.cpp (right):

https://codereview.chromium.org/846023003/diff/1/src/pdf/SkPDFDocument.cpp#ne...
src/pdf/SkPDFDocument.cpp:91: void stream(SkPDFObject* obj) {
nit: space between functions

https://codereview.chromium.org/846023003/diff/1/src/pdf/SkPDFPage.cpp
File src/pdf/SkPDFPage.cpp (left):

https://codereview.chromium.org/846023003/diff/1/src/pdf/SkPDFPage.cpp#oldcode57
src/pdf/SkPDFPage.cpp:57: fContentStream->emitIndirectObject(stream, catalog);
this used to emit an indirectObject, but Streamer just calls obj->emit.  Seems
like a behavior change.

[hal.canary, 2015-01-13 14:00:27]

https://codereview.chromium.org/846023003/diff/1/src/pdf/SkPDFDocument.cpp
File src/pdf/SkPDFDocument.cpp (right):

https://codereview.chromium.org/846023003/diff/1/src/pdf/SkPDFDocument.cpp#ne...
src/pdf/SkPDFDocument.cpp:91: void stream(SkPDFObject* obj) {
On 2015/01/13 13:49:47, djsollen wrote:
> nit: space between functions

Done.

https://codereview.chromium.org/846023003/diff/1/src/pdf/SkPDFPage.cpp
File src/pdf/SkPDFPage.cpp (left):

https://codereview.chromium.org/846023003/diff/1/src/pdf/SkPDFPage.cpp#oldcode57
src/pdf/SkPDFPage.cpp:57: fContentStream->emitIndirectObject(stream, catalog);
On 2015/01/13 13:49:47, djsollen wrote:
> this used to emit an indirectObject, but Streamer just calls obj->emit.  Seems
like a behavior change.

Very good point.  This inconsistency was bothering me.  Pages never have
substitute objects, so emit(..., true) just calls emitIndirectObject(...).

Also, I have tested on all of our GMs and 61 SKPs and this change produces no
different output.

[djsollen, 2015-01-13 14:35:03]

As long as pages don't have indirect objects then this LGTM

[hal.canary, 2015-01-13 15:03:32]

The CQ bit was checked by halcanary@google.com

[commit-bot: I haz the power, 2015-01-13 15:04:10]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/846023003/20001

[commit-bot: I haz the power, 2015-01-13 15:13:02]

Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/f361b714390422a5c2a8b1dacb8e67502d0e40bb