Update references to global object after deserializing context.

Update references to global object after deserializing context.

R=jochen@chromium.org
TEST=test-serialize/CustomContext{Des,S}erialization

Also test by
- make ia32.debug embedscript=<full path to mjsunit.js>
- d8 -e "assertDoesNotThrow('print(1)')"

Committed: https://crrev.com/bcab9eacf3529758bb4fb677edb7cfab62a938ba
Cr-Commit-Position: refs/heads/master@{#26035}

[Yang, 2015-01-12 15:49:05]

https://codereview.chromium.org/846023002/diff/1/test/cctest/test-serialize.cc
File test/cctest/test-serialize.cc (right):

https://codereview.chromium.org/846023002/diff/1/test/cctest/test-serialize.c...
test/cctest/test-serialize.cc:557: "})();");
Compared to the previous ContextSerialization test, this part is the only
difference.

[jochen (gone - plz use gerrit), 2015-01-12 19:57:11]

lgtm with nits

https://codereview.chromium.org/846023002/diff/1/src/bootstrapper.cc
File src/bootstrapper.cc (right):

https://codereview.chromium.org/846023002/diff/1/src/bootstrapper.cc#newcode884
src/bootstrapper.cc:884: for (int i = 0; i < outdated_contexts->length(); i++) {
nit. ++i

https://codereview.chromium.org/846023002/diff/1/src/serialize.cc
File src/serialize.cc (right):

https://codereview.chromium.org/846023002/diff/1/src/serialize.cc#newcode639
src/serialize.cc:639: DCHECK(reservations_[i].length() > 0);
wrap the entire loop in #if DEBUG?

https://codereview.chromium.org/846023002/diff/1/src/snapshot-common.cc
File src/snapshot-common.cc (right):

https://codereview.chromium.org/846023002/diff/1/src/snapshot-common.cc#newco...
src/snapshot-common.cc:56: CHECK(result->IsContext());
maybe also check that the outdated contexts is a fixed array?

[Yang, 2015-01-13 08:20:11]

https://codereview.chromium.org/846023002/diff/1/src/bootstrapper.cc
File src/bootstrapper.cc (right):

https://codereview.chromium.org/846023002/diff/1/src/bootstrapper.cc#newcode884
src/bootstrapper.cc:884: for (int i = 0; i < outdated_contexts->length(); i++) {
On 2015/01/12 19:57:10, jochen (slow) wrote:
> nit. ++i

Done.

https://codereview.chromium.org/846023002/diff/1/src/serialize.cc
File src/serialize.cc (right):

https://codereview.chromium.org/846023002/diff/1/src/serialize.cc#newcode639
src/serialize.cc:639: DCHECK(reservations_[i].length() > 0);
On 2015/01/12 19:57:10, jochen (slow) wrote:
> wrap the entire loop in #if DEBUG?

Done.

https://codereview.chromium.org/846023002/diff/1/src/snapshot-common.cc
File src/snapshot-common.cc (right):

https://codereview.chromium.org/846023002/diff/1/src/snapshot-common.cc#newco...
src/snapshot-common.cc:56: CHECK(result->IsContext());
On 2015/01/12 19:57:10, jochen (slow) wrote:
> maybe also check that the outdated contexts is a fixed array?

Added the check to DeserializePartial, where its casted to FixedArray.

[Yang, 2015-01-13 08:20:13]

The CQ bit was checked by yangguo@chromium.org

[commit-bot: I haz the power, 2015-01-13 08:20:44]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/846023002/20001

[commit-bot: I haz the power, 2015-01-13 08:48:05]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-01-13 08:48:17]

Patchset 2 (id:??) landed as
https://crrev.com/bcab9eacf3529758bb4fb677edb7cfab62a938ba
Cr-Commit-Position: refs/heads/master@{#26035}